-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45816/#review127706
-----------------------------------------------------------


Ship it!




Josh asked me offline to take a look at this and everything LGTM.

It took me a bit to understand the mechanics but it seems to be a robust enough 
solution.

- Zameer Manji


On April 7, 2016, 10:29 a.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45816/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 10:29 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Bill Farner.
> 
> 
> Bugs: AURORA-1648
>     https://issues.apache.org/jira/browse/AURORA-1648
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add support for automated DB migrations and rollbacks when restoring from 
> dbScript stored in a snapshot.
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md ebc252f2d2f0e0c25bd2752247f0b9d4ebdd64b5 
>   build.gradle ad5ec5c4afe4dd5c2189d0680692a7409f0417a9 
>   config/checkstyle/suppressions.xml 50a53e0d96cb365b2182b78769c1749b7e3558a9 
>   docs/development/db-migration.md PRE-CREATION 
>   docs/development/thrift.md 7f098c25351289510f160f85f554775b4401e37a 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> ecdaa7ee0af5d1cc4bb6a226bd7ef060d2685a7f 
>   
> src/main/java/org/apache/aurora/scheduler/storage/backup/TemporaryStorage.java
>  5c7d92f00ddda0a1f366ba1ca33b61829fa16ad9 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbModule.java 
> baf460e987d0a6ba2810507695fe118b6b502f87 
>   src/main/java/org/apache/aurora/scheduler/storage/db/DbUtil.java 
> 6f4e6710863a301238043edbb7bed1c7923a0720 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManager.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImpl.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/storage/db/MigrationMapper.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/MigrationChangelogEntry.java
>  PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImpl.java 
> 6fee2510d044515e0704cf20ec0ba77231050ec4 
>   
> src/main/resources/org/apache/aurora/scheduler/storage/db/MigrationMapper.xml 
> PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/MigrationManagerImplIT.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/storage/db/testmigration/V001_TestMigration.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java
>  d93eed925d289381cdac547ad1bce749c397a07f 
> 
> Diff: https://reviews.apache.org/r/45816/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew build -Pq
> 
> end to end tests.
> 
> Also manually verified that migrations and rollbacks are correctly performed 
> in vagrant.
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Reply via email to