-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45902/#review127708
-----------------------------------------------------------




src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
 (line 108)
<https://reviews.apache.org/r/45902/#comment191097>

    Shouldn't this be fatal? To me to looks like this exception can only throw 
if there is a ZK problem `data.getData()` is null, or the data is malformed 
(bug in a follower).


- Zameer Manji


On April 7, 2016, 4:07 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45902/
> -----------------------------------------------------------
> 
> (Updated April 7, 2016, 4:07 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1468
>     https://issues.apache.org/jira/browse/AURORA-1468
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> build.gradle                                                                  
>           |   5 ++
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>      |  94 +++++++++++++++++++++++
>  
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java
>  | 205 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 304 insertions(+)
> 
> 
> Diffs
> -----
> 
>   build.gradle ad5ec5c4afe4dd5c2189d0680692a7409f0417a9 
>   
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/45902/diff/
> 
> 
> Testing
> -------
> 
> Locally green: `./gradlew -Pq build`.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to