----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45935/#review127831 -----------------------------------------------------------
This patch does not apply cleanly against master (5ecded7), do you need to rebase? I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On April 8, 2016, 6:16 p.m., Bill Farner wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45935/ > ----------------------------------------------------------- > > (Updated April 8, 2016, 6:16 p.m.) > > > Review request for Aurora and Zameer Manji. > > > Repository: aurora > > > Description > ------- > > This was an obscure feature that brings no value. The args system had this > to support a mono-repo, where collisions of arg 'short names' was possible. > > Removing this has the side-effect of making the scheduler's help text > ever-so-slightly less daunting. I've also changed the formatting in help > text to make it more apparent when default values are present. See > `scheduler-configuration.md`. > > > Diffs > ----- > > RELEASE-NOTES.md 46fa2d4d9bac6788cb322789a2ae0e84d55fb435 > commons/src/main/java/org/apache/aurora/common/args/ArgScanner.java > 908553ce2fdb16d0e69b458823deb7f165550b93 > commons/src/main/java/org/apache/aurora/common/args/ArgumentInfo.java > ca309a2b3d44f94e9f91d0690f810fe7bc646aed > commons/src/main/java/org/apache/aurora/common/args/OptionInfo.java > 12714949f433ec6b5d7c2794c2f31d82773174e7 > commons/src/main/java/org/apache/aurora/common/args/PositionalInfo.java > 48737d4a831ab62945e48e4b9540a18ca2e2abab > commons/src/test/java/org/apache/aurora/common/args/ArgScannerTest.java > a4d74ed9d9093939dbaf088ba2a8a632b2a7f1c5 > commons/src/test/java/org/apache/aurora/common/args/OptionInfoTest.java > 98d951912627bfbf49e75037bccc914a430a45f4 > docs/reference/scheduler-configuration.md > e6c0bb60281d7c39c2aa235445ee4c1ef97464ba > > Diff: https://reviews.apache.org/r/45935/diff/ > > > Testing > ------- > > > Thanks, > > Bill Farner > >
