Re: Review Request 46111: Introduce a Curator-based `SingletonService`.

[Aurora ReviewBot]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46111/#review128545
-----------------------------------------------------------



Master (3cb599e) is red with this patch.
  ./build-support/jenkins/build.sh

                           with temporary_dir() as checkpoint_root:
                             te = AuroraExecutor(
                     >           
runner_provider=make_provider(checkpoint_root),
                                 
sandbox_provider=DefaultTestSandboxProvider())
                     
                     
src/test/python/apache/aurora/executor/test_thermos_executor.py:580: 
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
src/test/python/apache/aurora/executor/test_thermos_executor.py:193: in 
make_provider
                         pex_location=thermos_runner_path(),
                     _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
                     
                     build = True
                     
                         def thermos_runner_path(build=True):
                           if not build:
                             return getattr(thermos_runner_path, 'value', 
None)
                         
                           if not hasattr(thermos_runner_path, 'value'):
                             pex_dir = safe_mkdtemp()
                     >       assert subprocess.call(["./pants", 
"--pants-distdir=%s" % pex_dir, "binary",
                               
"src/main/python/apache/thermos/runner:thermos_runner"]) == 0
                     E       assert 1 == 0
                     E        +  where 1 = <function call at 
0x7fbec0f939b0>(['./pants', '--pants-distdir=/tmp/user/10021/tmp_3YC6Y', 
'binary', 'src/main/python/apache/thermos/runner:thermos_runner'])
                     E        +    where <function call at 
0x7fbec0f939b0> = subprocess.call
                     
                     
src/test/python/apache/aurora/executor/test_thermos_executor.py:185: 
AssertionError
                     -------------- Captured stderr call --------------
                     Traceback (most recent call last):
                       File 
"/home/jenkins/.cache/pants/setup/bootstrap-Linux-x86_64/0.0.80/bin/pants", 
line 7, in <module>
                         from pants.bin.pants_exe import main
                     ImportError: No module named pants.bin.pants_exe
                      generated xml file: 
/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results/415337499eb72578eab327a6487c1f5c9452b3d6.xml
 
                      16 failed, 631 passed, 6 skipped, 1 warnings, 8 
error in 195.35 seconds 
                     
FAILURE


               Waiting for background workers to finish.
22:06:52 04:54   [complete]
               FAILURE


I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On April 12, 2016, 9:21 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46111/
> -----------------------------------------------------------
> 
> (Updated April 12, 2016, 9:21 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1468
>     https://issues.apache.org/jira/browse/AURORA-1468
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java
>             |   4 ++
>  
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
>  |   2 +-
>  
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>           | 191 +++++++++++++++++++++++++++++++++++++++++++++++++
>  
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java
>          | 114 +++++++++++++++++++++++++++++
>  
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java
>    | 108 +++++-----------------------
>  
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java
>       | 194 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  6 files changed, 523 insertions(+), 90 deletions(-)
> 
> 
> Diffs
> -----
> 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/SingletonService.java
>  3561d07f65d11060e4a96c9df06af44107a73430 
>   
> commons/src/main/java/org/apache/aurora/common/zookeeper/testing/ZooKeeperTestServer.java
>  0ab24faadcba60ff8e68b2036562e4d39a4ac874 
>   
> src/main/java/org/apache/aurora/scheduler/discovery/CuratorSingletonService.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/discovery/BaseCuratorDiscoveryTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java
>  559838984a519bdbbb9ed60a71cea726dcd5cb52 
>   
> src/test/java/org/apache/aurora/scheduler/discovery/CuratorSingletonServiceTest.java
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46111/diff/
> 
> 
> Testing
> -------
> 
> Locally green: `./gradlew -Pq build`.
> 
> NB: The SingletonServiceImplTest has more coverage and code surrounding 
> illegal state transitions - double advertisement, double leave, advertise 
> after leave (enforcing single-use).  I can add those sorts of checks and test 
> for the checks, but thought I'd leave this 1st RB here to reduce clutter and 
> follow-up if folks want those sorts of checks.
> 
> 
> Thanks,
> 
> John Sirois
> 
>