----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46167/#review128765 -----------------------------------------------------------
Ship it! commons/src/main/java/org/apache/aurora/common/base/Closures.java (lines 49 - 50) <https://reviews.apache.org/r/46167/#comment192228> s/closure/consumer/ ? - John Sirois On April 13, 2016, 3:32 p.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46167/ > ----------------------------------------------------------- > > (Updated April 13, 2016, 3:32 p.m.) > > > Review request for Aurora, John Sirois and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > Commons came with a `Closure` type which is identical to the Java 8 type > `Consumer`. This replaces the former with the latter in the interests of > reducing the commons code and fork. > > > Diffs > ----- > > commons/src/main/java/org/apache/aurora/common/base/Closure.java > 42c9d11974f0d0aa4408404b1ed67ee202fc1742 > commons/src/main/java/org/apache/aurora/common/base/Closures.java > 0953119ced73eefa897351c59e767bb7e52fcbdd > commons/src/main/java/org/apache/aurora/common/util/StateMachine.java > e8aa00054799b4d06aacc41b857b98527bf02720 > > commons/src/main/java/org/apache/aurora/common/util/templating/StringTemplateHelper.java > bcfa003b2220e6dd53aee7306e068a4e619877c4 > commons/src/test/java/org/apache/aurora/common/base/ClosuresTest.java > 07bf23c99e1624ef98beaac5763549db28d78c69 > commons/src/test/java/org/apache/aurora/common/util/StateMachineTest.java > 9591e824354b6d98811aa3ca0e99cb24258881ae > src/main/java/org/apache/aurora/scheduler/SchedulerLifecycle.java > debe89934f424a3dfc151cd489acfc280d074a59 > src/main/java/org/apache/aurora/scheduler/http/JerseyTemplateServlet.java > 302388d78c833a394cfab84342028da9d26660ad > src/main/java/org/apache/aurora/scheduler/state/TaskStateMachine.java > 6fd29512ace01f98024fd3b6db00e6c903ea8b89 > src/main/java/org/apache/aurora/scheduler/storage/log/LogStorage.java > 5143668c8dacb2d8695cf8299abf2e6fab536de2 > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManager.java > 76a574fd4fb18e0afd8da6387286b72cc583b7fd > > src/main/java/org/apache/aurora/scheduler/storage/log/StreamManagerImpl.java > 766ec2d51ac875ce263d7e4ad8827424555b5b5e > src/test/java/org/apache/aurora/scheduler/storage/log/LogManagerTest.java > 0256c06ee0794bf50bccaa283c5086da7642f3f6 > > Diff: https://reviews.apache.org/r/46167/diff/ > > > Testing > ------- > > > Thanks, > > Zameer Manji > >
