-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46171/#review128785
-----------------------------------------------------------


Ship it!




Ship It!

- Bill Farner


On April 13, 2016, 3:18 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46171/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 3:18 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1468
>     https://issues.apache.org/jira/browse/AURORA-1468
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This moves `ZooKeeperClient` configuration to the discovery package and
> factors `ZooKeeperConfig` up out of the `ZooKeeperClientModule`
> for re-use as ZooKeeper config data by Curator.
> 
>  config/legacy_untested_classes.txt                                           
>                                                                 | 14 ++++----
>  src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java             
>                                                                 | 10 +++---
>  
> src/main/java/org/apache/aurora/scheduler/{zookeeper/guice/client/flagged/FlaggedClientConfig.java
>  => discovery/FlaggedZooKeeperConfig.java} | 14 ++++----
>  src/main/java/org/apache/aurora/scheduler/{zookeeper/guice/client => 
> discovery}/ZooKeeperClientModule.java                                   | 84 
> ++++----------------------------------------
>  src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java     
>                                                                 | 94 
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>  
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
>                                                                | 12 ++++---
>  src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java               
>                                                                 |  6 ++--
>  src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java 
>                                                                 | 79 
> ++++++++++++++++++++++++++++++++++++++++++
>  8 files changed, 210 insertions(+), 103 deletions(-)
> 
> 
> Diffs
> -----
> 
>   config/legacy_untested_classes.txt 00e166690401dd773f1dcae1ef10ac59f73d74ed 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 6c7ae7e66770fd766ef41f86501e08310a6bc698 
>   src/main/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfig.java 
> PRE-CREATION 
>   
> src/main/java/org/apache/aurora/scheduler/log/mesos/MesosLogStreamModule.java 
> b20ea5da59152b0f71cf593efebcbc796a5632aa 
>   
> src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/ZooKeeperClientModule.java
>  cab3691dc4b1cbc9c4cb18153f483262ccf7c8da 
>   
> src/main/java/org/apache/aurora/scheduler/zookeeper/guice/client/flagged/FlaggedClientConfig.java
>  92f367319eb8cbf516790ca4c4aec2ce0e5dce22 
>   src/test/java/org/apache/aurora/scheduler/app/SchedulerIT.java 
> 88d3e3e18a73a086f1579bb50c4d39b1ec5a00e8 
>   
> src/test/java/org/apache/aurora/scheduler/discovery/ZooKeeperConfigTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/46171/diff/
> 
> 
> Testing
> -------
> 
> Locally green:
> ```
> ./gradlew -Pq build
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to