-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46290/#review129381
-----------------------------------------------------------




RELEASE-NOTES.md (line 6)
<https://reviews.apache.org/r/46290/#comment192817>

    This doesn't match the flag.



src/main/python/apache/aurora/executor/bin/thermos_executor_main.py (line 102)
<https://reviews.apache.org/r/46290/#comment192818>

    Flags that read as a double-negative are confusing, let's avoid that if we 
can.
    
    e.g. `--do-not-demote-health-check-to-role=false`
    
    Can you invert this to 'point positive' instead?
    
    e.g. `--root-health-checks`


- Bill Farner


On April 15, 2016, 4:59 p.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46290/
> -----------------------------------------------------------
> 
> (Updated April 15, 2016, 4:59 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Bugs: AURORA-1666
>     https://issues.apache.org/jira/browse/AURORA-1666
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> adding do-not-demote-health-check-to-role flag to not demote health check 
> user:group to role
> 
> 
> Diffs
> -----
> 
>   RELEASE-NOTES.md a0536ec352119952d4d58aa5f36e5e9a7b7d2e6e 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 40a0cd6396a78c591debf5e2be11363ecf496231 
>   src/main/python/apache/aurora/executor/common/health_checker.py 
> d8675beb8f16ebdd2d6946367784411fe84a5cfc 
>   src/test/python/apache/aurora/executor/common/test_health_checker.py 
> 4ab7a2fab651abd5ab8a0f312d10c444800e8b7a 
> 
> Diff: https://reviews.apache.org/r/46290/diff/
> 
> 
> Testing
> -------
> 
> - end to end tests
> - added unit tests
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Reply via email to