> On avr. 19, 2016, 6:32 après-midi, John Sirois wrote:
> > Thanks for plugging away at this.  It sounds like you were trying to get 
> > versions like '0.13.1-SNAPSHOT' working but they still don't (see below).  
> > As such I'm not sure what the new AURORA_INTERNAL_VERSION is buying.

AURORA_INTERNAL_VERSION is a way for rpmbuild to properly unpack the tgz 
archive created with git archive (used in %setup -n).

But the whole thing is working by passing a version number without "-SNAPSHOT".
As stated above, I'm now able to build using `./build-artifact.sh 
/tmp/snapshot.tar.gz 0.13.2`, even on the 0.13.1-SNAPSHOT sources.
This will produce 0.13.2 debs and rpms.

This doesn't fully resolve AURORA-1568 if the purpose was to build -SNAPSHOT 
rpms. The idea here would be to use the Release attribute of the spec file. 
From my point of view, this is out of the scope of this review. What do you 
think ?


- Pierre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review129587
-----------------------------------------------------------


On avr. 19, 2016, 5:48 après-midi, Pierre Cheynier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> -----------------------------------------------------------
> 
> (Updated avr. 19, 2016, 5:48 après-midi)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> An operator should be able to build Aurora on his platform without
> relying on Docker.
> 
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
> 
> 
> Diffs
> -----
> 
>   builder/deb/debian-jessie/Dockerfile 
> fd15dfe6fd4518cfe9915b7339c1b3e609e968d7 
>   builder/deb/debian-jessie/pants.ini 
> 446ea8d8ebb4fce2665dc4c7c1a2ea32d5f18707 
>   builder/deb/ubuntu-trusty/Dockerfile 
> a4a9e648537841583fdc02c006bfa00a3a095aca 
>   builder/deb/ubuntu-trusty/pants.ini  
>   builder/rpm/centos-7/Dockerfile a4d9dfcee5637d23333c31d0c2b63a9ebcf04e8d 
>   builder/rpm/centos-7/build.sh be3c6fb970dbdd1b94630473e6f67e4a91700e43 
>   builder/rpm/centos-7/pants.ini  
>   specs/debian/control 9dd927df63f68afc10506a7dcab8d26f21fbee33 
>   specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d 
>   specs/rpm/Makefile 0476bcbda489bf53edc2101831475fe4a4ea3241 
>   specs/rpm/aurora.spec fa89242f0c39ca058bc791dab18f67f75150e2d2 
> 
> Diff: https://reviews.apache.org/r/45298/diff/
> 
> 
> Testing
> -------
> 
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
> 
> 
> Thanks,
> 
> Pierre Cheynier
> 
>

Reply via email to