-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46596/
-----------------------------------------------------------

(Updated April 28, 2016, 12:44 a.m.)


Review request for Aurora, Maxim Khutornenko and Zameer Manji.


Changes
-------

Fix line length + Rebase.


Bugs: AURORA-945
    https://issues.apache.org/jira/browse/AURORA-945


Repository: aurora


Description
-------

This commit introduces a new command line flag `-framework_name` and changes 
the value from the hardcoded 'TwitterScheduler' to 'aurora'.

This change is non-intrusive as 
https://issues.apache.org/jira/browse/MESOS-2614 has been fixed. The new value 
will be shown on the UI and used for Mesos DNS. I have skipped a deprecation 
cycle for this change, as if an operator wants to maintain the old value, he 
can simply use the new option when deploying the next Aurora version.


Diffs (updated)
-----

  RELEASE-NOTES.md 7a37d0d69f688bece624628fe5b98efc85d506a2 
  docs/features/service-discovery.md f242730fc16103903167182372ff6903127d73f5 
  docs/reference/scheduler-configuration.md 
d2262f79edfde23eccd87bae7f1cf319b63b1103 
  
src/main/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModule.java
 5c6cdd2b4c7ee92eb7d8e1649a95cad3035efec0 
  
src/test/java/org/apache/aurora/scheduler/mesos/CommandLineDriverSettingsModuleTest.java
 dc964b8dac1b8e21e86ad331216c57fa11abeb6d 

Diff: https://reviews.apache.org/r/46596/diff/


Testing
-------

* ./gradlew -Pq build
* Changed the framework name in vagrant. Aurora happily re-registered without a 
fallout.


Thanks,

Stephan Erb

Reply via email to