-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46897/#review131355
-----------------------------------------------------------


Ship it!




Ship It!

- Joshua Cohen


On May 2, 2016, 6:14 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46897/
> -----------------------------------------------------------
> 
> (Updated May 2, 2016, 6:14 p.m.)
> 
> 
> Review request for Aurora, Benjamin Staffin and Joshua Cohen.
> 
> 
> Bugs: AURORA-1687
>     https://issues.apache.org/jira/browse/AURORA-1687
> 
> 
> Repository: aurora-packaging
> 
> 
> Description
> -------
> 
> This makes us more robust to upstream packaging changes.  The `gdebi`
> tool gives us `apt-get install` dependency calculation, fetching and
> install for a local deb package.
> 
>  builder/deb/debian-jessie/Dockerfile |  5 +++--
>  builder/deb/ubuntu-trusty/Dockerfile | 11 ++++++-----
>  2 files changed, 9 insertions(+), 7 deletions(-)
> 
> 
> Diffs
> -----
> 
>   builder/deb/debian-jessie/Dockerfile 
> 50b50817ba24db6b226e30746064627b79152aff 
>   builder/deb/ubuntu-trusty/Dockerfile 
> 21617e79927af6c529ae0e0f2e47b027989444ac 
> 
> Diff: https://reviews.apache.org/r/46897/diff/
> 
> 
> Testing
> -------
> 
> Locally before [this 
> fix](https://github.com/benley/gradle-packaging/commit/d5388990bf2daa85f40bd09259373e5360018249)
> ```
> ./build-artifact.sh builder/deb/ubuntu-trusty /tmp/snapshot.tar.gz 
> 0.13.1-SNAPSHOT
> ```
> 
> Observed the java 7 package get pulled to satisfy the java-runtime
> dependency of the gradle package.  Not ideal, but it allowed the build
> to succeed since we control the default java (used by gradle) with
> `update-alternatives` higher in the `Dockerfile`.
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to