> On May 4, 2016, 2:29 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java,
> >  line 34
> > <https://reviews.apache.org/r/46948/diff/1/?file=1370195#file1370195line34>
> >
> >     Can you add tests for these classes?

These are already tested in MesosResourceConverterTest: 
https://reviews.apache.org/r/46948/diff/1#7


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46948/#review131680
-----------------------------------------------------------


On May 3, 2016, 9:11 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46948/
> -----------------------------------------------------------
> 
> (Updated May 3, 2016, 9:11 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> A trivial patch to replace mesos type with the converter object in 
> `ResourceType`. 
> 
> This is mostly an attempt to offload this standalone change from the upcoming 
> larger diff that will introduce a unified approach of handling 
> `ResourceAggregate` and `ResourceSlot` data.
> 
> 
> Diffs
> -----
> 
>   
> src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java
>  PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 
> 8b42bf0d2f4a4a19e52875440d825bc6ee553f3b 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
> ee2b51a587271457c5f1e0bcec6885bb4d0bc68f 
>   
> src/main/java/org/apache/aurora/scheduler/resources/ResourceTypeConverter.java
>  11395ecfdb701e7c6197b971482cb70a257fb06e 
>   src/main/java/org/apache/aurora/scheduler/resources/Resources.java 
> 36d1de85658afd5b0d933e833c7193c60afdfd9c 
>   src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResource.java 
> dc7e97d1ea1f74594310bc346f18f2ed547f007d 
>   
> src/main/java/org/apache/aurora/scheduler/storage/db/views/DBResourceAggregate.java
>  8c5d1f014cd448dbd2fdfa798ac8a3323855861f 
>   
> src/test/java/org/apache/aurora/scheduler/resources/MesosResourceConverterTest.java
>  PRE-CREATION 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 
> b6810b18677b9e030ad84a214ca7dc6746990d4f 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
> 1583cefd568f4ed71f6953d5da0e2b25555035bc 
>   
> src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeConverterTest.java
>  78da84a9500de93025db5180c1d98a0669d62ec6 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeTest.java 
> dc9dc668e9f0a7484c62950834b5ae8cae2a1887 
> 
> Diff: https://reviews.apache.org/r/46948/diff/
> 
> 
> Testing
> -------
> 
> ./gradlew -Pq build
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to