-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46997/
-----------------------------------------------------------

(Updated May 6, 2016, 12:36 a.m.)


Review request for Aurora, Joshua Cohen and Bill Farner.


Changes
-------

Dropped key check enforcement in ResourceBag.binaryOp(). It's perfectly legal 
to manipulate bags without exact key count (e.g. when counting slots). The new 
behavior is: apply binaryOp to matching vector keys OR keep the bag value 
unchanged. While not ideal, it's more logical than selective binaryOp 
application (e.g. union in case of "add" and noop in case of "divide").


Repository: aurora


Description
-------

This patch further generifies resource management by removing 
`ResourceAggregates` and `IResourceAggregate` from quota and stat calculation 
paths. 

The new `ResourceBag` intends to replace both `IResourceAggregate` and 
`ResourceSlot` (coming later) for the purposes of internal resource 
calculations. 

The bulk of the changes in `ResourceBag` and `ResourceManager`, the rest is 
mostly adjusting call sites to convert from `IResourceAggregate`.


Diffs (updated)
-----

  
src/main/java/org/apache/aurora/scheduler/preemptor/PreemptionVictimFilter.java 
9a37ee7a99818138e53a6d4665e0b09930d1cd45 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaCheckResult.java 
3437c65af27993ea50bf39d322558fb64a645da1 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaInfo.java 
1df21b8d82ee48fd4d2f11d77aa419dd91c2a33c 
  src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
bf476aa3d5647be45b2525965e735d80dbfbf0f4 
  src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java 
a735b0b2406cffcea06d13d1af1a5278a94b14d3 
  
src/main/java/org/apache/aurora/scheduler/resources/AuroraResourceConverter.java
 f9c89a9a0bfcbb19c602545d5ba19d371677f6bf 
  src/main/java/org/apache/aurora/scheduler/resources/ResourceAggregates.java 
1d19b322739c2c48f7d8009ca8bbf0d116a10eec 
  src/main/java/org/apache/aurora/scheduler/resources/ResourceBag.java 
PRE-CREATION 
  src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 
1b88fc3178c44c5e21a9e5ffb432bddbf8f7098f 
  src/main/java/org/apache/aurora/scheduler/resources/ResourceSlot.java 
a8dee95df8fd2a5a7546618ebdbc3cce7dabf8c3 
  src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
baed3de58a5e6af8dbb9a64038aa31858e276741 
  src/main/java/org/apache/aurora/scheduler/resources/Resources.java 
94cd1636da860e27b6c2bd8a641852e4a45cbb04 
  src/main/java/org/apache/aurora/scheduler/sla/SlaGroup.java 
2c044a625b52ef0303b2eff08fc946b6b4b36036 
  src/main/java/org/apache/aurora/scheduler/stats/AsyncStatsModule.java 
03dfa27a701e26415753006574aae62297c09660 
  src/main/java/org/apache/aurora/scheduler/stats/SlotSizeCounter.java 
1f71b00e1fc7e1061ad28d9947b4d45378dd7f78 
  src/main/java/org/apache/aurora/scheduler/storage/log/ThriftBackfill.java 
d1c62a839508d11c0fd4f5795d2efde42c62fe82 
  src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
bab34d8abd02d2d0bca06f7cf0e0bca7e11d8869 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaCheckResultTest.java 
d989900d736ad10df07fb419d147eb6646fd5d4a 
  src/test/java/org/apache/aurora/scheduler/quota/QuotaManagerImplTest.java 
d591d0fd246dc71d3be82ec39f286b566d68ee12 
  src/test/java/org/apache/aurora/scheduler/resources/ResourceBagTest.java 
PRE-CREATION 
  src/test/java/org/apache/aurora/scheduler/resources/ResourceManagerTest.java 
c53a21d127a58fe90f4974d62afb613805f121f0 
  src/test/java/org/apache/aurora/scheduler/resources/ResourceSlotTest.java 
0e6a5ac911a1975f3ace4fa62fdb76b39b8a62b0 
  src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
821c47fae50077959cd8a60e24b6be24f9e2c928 
  src/test/java/org/apache/aurora/scheduler/resources/ResourcesTest.java 
185338e6f0d49281333594302316a2f57e9a4aea 
  src/test/java/org/apache/aurora/scheduler/stats/AsyncStatsModuleTest.java 
7fcf47aa1a9b20404a880e17db4da4b19d805831 
  src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java 
b1c8f75a5b377623ed2afa8acdcf9c8654e4ff4c 
  
src/test/java/org/apache/aurora/scheduler/storage/log/SnapshotStoreImplIT.java 
aeab07d3e5a1215cb5327d456a5720ec99eb8b71 
  src/test/java/org/apache/aurora/scheduler/thrift/Fixtures.java 
a2e2395244661f87e47828e07cf7d866d44388ec 
  
src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java 
3a2b3f39b7f47b88afe4dca7933b43fd20ea5c5b 

Diff: https://reviews.apache.org/r/46997/diff/


Testing
-------

./gradlew -Pq build


Thanks,

Maxim Khutornenko

Reply via email to