-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47261/
-----------------------------------------------------------

(Updated May 11, 2016, 10:35 p.m.)


Review request for Aurora and Joshua Cohen.


Changes
-------

Fixing compare order in unit test.


Repository: aurora


Description
-------

This patch moves `AcceptedOffer` onto a new resource model. 

Not particularly happy with the unchecked suppression but all alternatives 
required handling different mesos resource types outside of the 
`MesosResourceConverter`, which was less than ideal. Happy to consider any 
suggestions here.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/base/Numbers.java 
703ca3b707320bbda48fa89c45404093b241e785 
  src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
ef1b5bc2990035ba359509c861fb44ff27b5b8fe 
  src/main/java/org/apache/aurora/scheduler/mesos/TestExecutorSettings.java 
46973b8b641686231b9c4f1807ade56790386041 
  src/main/java/org/apache/aurora/scheduler/resources/AcceptedOffer.java 
fce6621bc3fd88a9b891fb464e28bf5da0c3867b 
  
src/main/java/org/apache/aurora/scheduler/resources/MesosResourceConverter.java 
f3fe05cadd93e99e2a6f2f644b7f850ce9647d03 
  src/main/java/org/apache/aurora/scheduler/resources/ResourceManager.java 
3b38469b4819f9ae232c468df8ba652f25001ad3 
  src/main/java/org/apache/aurora/scheduler/resources/ResourceMapper.java 
c8e11a406f8a0d19d4e3abf08ab46c27a4003e38 
  src/main/java/org/apache/aurora/scheduler/resources/ResourceSlot.java 
dea7943d40eef1c31663c506a06b8e933f8e6dd2 
  src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
276320ae03f93a5351c9d3648dd35f578f6e4cfe 
  src/test/java/org/apache/aurora/scheduler/resources/AcceptedOfferTest.java 
36c5c115e9e7ca0bc0e3b34e4148edf349d1e874 
  
src/test/java/org/apache/aurora/scheduler/resources/MesosResourceConverterTest.java
 d4bb5aa1dcc846f8f4d4d153dd733a9c45537976 
  src/test/java/org/apache/aurora/scheduler/resources/ResourceTestUtil.java 
ba597b866275e438a113c58206abbb430cc2a535 

Diff: https://reviews.apache.org/r/47261/diff/


Testing
-------

./gradlew -Pq build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh


Thanks,

Maxim Khutornenko

Reply via email to