> On May 14, 2016, 1:54 p.m., Stephan Erb wrote: > > src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java, > > line 138 > > <https://reviews.apache.org/r/47373/diff/1/?file=1383293#file1383293line138> > > > > Is that really copy necessary?
Not really, the only reason it was there to simplify expectations in the unit test as `SingletonImmutableList` is inaccessible for construction as Guava-internal. Thanks for bringing this up though, it serves no good purpose, removed. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47373/#review133271 ----------------------------------------------------------- On May 13, 2016, 11:23 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47373/ > ----------------------------------------------------------- > > (Updated May 13, 2016, 11:23 p.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Repository: aurora > > > Description > ------- > > This helps alleviate master task reconciliation pressure in large clusters > that _may_ lead to unresponsiveness and subsequent loss of slaves given a > combination of other load factors. > > Default values are chosen somewhat randomly but have been battle tested. > Happy to consider other suggestions. > > > Diffs > ----- > > > src/main/java/org/apache/aurora/scheduler/reconciliation/ReconciliationModule.java > cccee083fc2e5f204c91a9d397beb451d4d9df40 > > src/main/java/org/apache/aurora/scheduler/reconciliation/TaskReconciler.java > 57d20618fe9eda076936d159172d5e133ec6597b > > src/test/java/org/apache/aurora/scheduler/reconciliation/TaskReconcilerTest.java > 5b4b3ac9781c9b572bbc9507c238dfa3b0177b45 > > src/test/java/org/apache/aurora/scheduler/testing/FakeScheduledExecutor.java > 9082a31d4d2ff454775f5160a474e31261628929 > > Diff: https://reviews.apache.org/r/47373/diff/ > > > Testing > ------- > > ./gradlew -Pq build > > > Thanks, > > Maxim Khutornenko > >
