-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47440/#review133479
-----------------------------------------------------------
Master (3cbff41) is red with this patch.
./build-support/jenkins/build.sh
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java:21:
error: File contains a sequence of empty lines.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/Webhook.java:18:
error: Wrong order for 'java.io.BufferedReader' import. Order should be: java,
javax, scala, com, net, org. Each group should be separated by a single
blank line.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/Webhook.java:18:8:
error: Unused import - java.io.BufferedReader.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/Webhook.java:21:8:
error: Unused import - java.io.InputStreamReader.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/Webhook.java:29:
error: File contains a sequence of empty lines.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/Webhook.java:36:31:
error: Name 'callMethod' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/Webhook.java:44:28:
error: '(' is preceded with whitespace.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/Webhook.java:45:
error: 'method def' child have incorrect indentation level 3, expected level
should be 4.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/Webhook.java:49:
error: File contains a sequence of empty lines.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/Webhook.java:58:
error: Line is longer than 100 characters (found 104).
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java:1:
error: File contains a sequence of empty lines.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java:1:
error: Line does not match expected header line of '^\/\*\*$'.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java:5:
error: 'org.codehaus.jackson.annotate.JsonCreator' should be separated from
previous imports.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java:19:
error: 'ctor def rparen' have incorrect indentation level 10, expected level
should be 2.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java:1:
error: Line does not match expected header line of '^\/\*\*$'.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java:9:
error: 'org.apache.aurora.common.args.Arg' should be separated from previous
imports.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java:17:
error: Wrong order for 'java.io.File' import. Order should be: java, javax,
scala, com, net, org. Each group should be separated by a single blank
line.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java:21:
error: File contains a sequence of empty lines.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java:42:
error: File contains a sequence of empty lines.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java:53:
error: File contains a sequence of empty lines.
[ant:checkstyle]
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java:88:
error: File contains a sequence of empty lines.
FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':checkstyleMain'.
> Checkstyle rule violations were found. See the report at:
> file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/checkstyle/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug
option to get more log output.
BUILD FAILED
Total time: 2 mins 5.039 secs
I will refresh this build result if you post a review containing "@ReviewBot
retry"
- Aurora ReviewBot
On May 17, 2016, 2:10 a.m., Dmitriy Shirchenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47440/
> -----------------------------------------------------------
>
> (Updated May 17, 2016, 2:10 a.m.)
>
>
> Review request for Aurora.
>
>
> Bugs: AURORA-1683
> https://issues.apache.org/jira/browse/AURORA-1683
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Looking for some feedback whether I'm on the correct path in adding a
> webhook. All comments are welcome!
>
>
> Diffs
> -----
>
> docs/reference/scheduler-configuration.md
> f7d676d0ed6bc536f4341dbb9365cf50e8607efb
> examples/vagrant/upstart/aurora-scheduler.conf
> 3d9e706de564df5e24cb34265bebc0db1cad11a0
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java
> 9ebfe230836e88a97bc60092373f72f176a8f6f2
> src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java
> 2a4c0665e48d30e0655de00bd7f6f9b49f01eafc
> src/main/java/org/apache/aurora/scheduler/events/Webhook.java PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java
> PRE-CREATION
> src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java
> PRE-CREATION
> src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION
> src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/47440/diff/
>
>
> Testing
> -------
>
> Need to fix tests.
>
>
> Thanks,
>
> Dmitriy Shirchenko
>
>
