> On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java, line 31 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385245#file1385245line31> > > > > move to previous line
Done. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java, line 29 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385245#file1385245line29> > > > > Offset is off here. Done. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java, lines > > 39-41 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385245#file1385245line39> > > > > formatting is off Done? > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java, line 24 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385245#file1385245line24> > > > > s/public/private here and below in favor of public getters. Done. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java, lines > > 32-33 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385245#file1385245line32> > > > > requireNonNull > > > > Also, wrap headers assignment with ImmutableMap.copyOf(). Done. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java, line > > 100 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385246#file1385246line100> > > > > remove Done. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java, line 77 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385246#file1385246line77> > > > > @VisibleForTesting Done. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java, line 57 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385246#file1385246line57> > > > > This constructor is not test-only. Done. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 57 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385244#file1385244line57> > > > > Consider this as fine or debug message to avoid polluting logs. TODO. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, lines 60-63 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385244#file1385244line60> > > > > Wrap into try-with-resources? Done. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 73 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385244#file1385244line73> > > > > This should be LOG.error(). Done. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 80 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385244#file1385244line80> > > > > This should be fine or debug instead. Done. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java, line 46 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385246#file1385246line46> > > > > Feels a bit redundant given the WEBHOOK_CONFIG_FILE. Have you > > considered controlling this feature by the config file presence? Done. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java, line 63 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385246#file1385246line63> > > > > s/public// > > > > Also, if you take my suggestion above this constructor should take file > > rather than flag arg. Done. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java, line 91 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385246#file1385246line91> > > > > This approach of reading config files looks pretty much identical to > > the one in TierModule. How about moving it into a new util class (e.g.: > > ConfigUtil alongside GuiceUtil) to reduce repetition? Yea, good idea! > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 45 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385244#file1385244line45> > > > > +1 > > > > Also, consider caching and reusing the connection in a `LoadingCache` > > [1] with `expireAfterAccess` set to close it due to inactivity. You can > > implementing disconnect() inside a `RemovalListener`. > > > > [1] - https://github.com/google/guava/wiki/CachesExplained Can you help me and clarify what we are trying to optimize here? I looked at https://docs.oracle.com/javase/8/docs/technotes/guides/net/http-keepalive.html and if I'm reading that correctly, at a layer below HTTPURLConnection, the actual connections are persisted. I added a Keep-Alive and removed disconnect. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 30 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385244#file1385244line30> > > > > Missing javadoc for class and public methods. Done. > On May 17, 2016, 5:09 p.m., Maxim Khutornenko wrote: > > docs/reference/scheduler-configuration.md, line 84 > > <https://reviews.apache.org/r/47440/diff/3/?file=1385240#file1385240line84> > > > > Formatting is off here and below. Done. - Dmitriy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review133555 ----------------------------------------------------------- On May 18, 2016, 9:12 p.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47440/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 9:12 p.m.) > > > Review request for Aurora. > > > Bugs: AURORA-1683 > https://issues.apache.org/jira/browse/AURORA-1683 > > > Repository: aurora > > > Description > ------- > > Looking for some feedback whether I'm on the correct path in adding a > webhook. All comments are welcome! > > > Diffs > ----- > > docs/reference/scheduler-configuration.md > f7d676d0ed6bc536f4341dbb9365cf50e8607efb > examples/vagrant/upstart/aurora-scheduler.conf > 3d9e706de564df5e24cb34265bebc0db1cad11a0 > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 9ebfe230836e88a97bc60092373f72f176a8f6f2 > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java > 2a4c0665e48d30e0655de00bd7f6f9b49f01eafc > src/main/java/org/apache/aurora/scheduler/events/Webhook.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java > PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION > src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47440/diff/ > > > Testing > ------- > > Need to fix tests. > > > Thanks, > > Dmitriy Shirchenko > >
