> On May 19, 2016, 2:14 a.m., Joshua Cohen wrote: > > src/main/java/org/apache/aurora/scheduler/resources/ResourceBag.java, line > > 182 > > <https://reviews.apache.org/r/47561/diff/1/?file=1387437#file1387437line182> > > > > s/by/with
Fixed. - Maxim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47561/#review133851 ----------------------------------------------------------- On May 18, 2016, 10:47 p.m., Maxim Khutornenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47561/ > ----------------------------------------------------------- > > (Updated May 18, 2016, 10:47 p.m.) > > > Review request for Aurora and Joshua Cohen. > > > Repository: aurora > > > Description > ------- > > The current `ResourceBag.binaryOp()` implementation may result in incorrect > slot size counting when mesos offer is missing particular resources. Changing > the algorithm to apply binary operator for the union of resource types with > missing values replaced by `0.0` thus making all ops fully commutative. > > Also, fixing scheduling benchmark that has been broken for quite some time > (https://reviews.apache.org/r/45177/) and then got even "more broken" by > https://reviews.apache.org/r/47325/. > > > Diffs > ----- > > src/jmh/java/org/apache/aurora/benchmark/Offers.java > 1dabe150230f80b7317d651c5976d25a257e7a00 > src/jmh/java/org/apache/aurora/benchmark/SchedulingBenchmarks.java > 1aa484cd73be45d515dfc0a4350c4feac37bba75 > src/jmh/java/org/apache/aurora/benchmark/Tasks.java > 4c4b03d9cf7fbb2b11c90b522fb14c2b754a1bc6 > src/main/java/org/apache/aurora/scheduler/resources/ResourceBag.java > 3cff94695094412806b64066d80b6fe30bf3fd59 > src/test/java/org/apache/aurora/scheduler/resources/ResourceBagTest.java > b8e64743321713cafd59ecaa67b4c8447410c215 > src/test/java/org/apache/aurora/scheduler/stats/SlotSizeCounterTest.java > e529e67debf7d3eccc8f29eec5752ca3b7446471 > > Diff: https://reviews.apache.org/r/47561/diff/ > > > Testing > ------- > > unit and e2e > > > Thanks, > > Maxim Khutornenko > >
