-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47550/
-----------------------------------------------------------

(Updated May 19, 2016, 7:28 p.m.)


Review request for Aurora.


Changes
-------

(1) Refactored duplicated code in updates.py and jobs.py to diff_formatter.py
(2) The diff messages are now displayed before the api.start_job_update() call 
is made
(3) Fixed broken tests and added a couple of new scenarios


Repository: aurora


Description
-------

AURORA-1492 Improve "aurora update start" command output


Diffs (updated)
-----

  src/main/python/apache/aurora/client/cli/diff_formatter.py PRE-CREATION 
  src/main/python/apache/aurora/client/cli/jobs.py 
e8bc38aaff42579419130b116389d9b9e09122a9 
  src/main/python/apache/aurora/client/cli/update.py 
eb7e9b0799bb25af652a0d5bde231cfca5bc1510 
  src/test/python/apache/aurora/client/cli/test_supdate.py 
2135ca988ce2f260262145a2168849acd8d14874 

Diff: https://reviews.apache.org/r/47550/diff/


Testing
-------

Automated: ./pants test.pytest --no-fast src/test/python::
Manual: using vagrant
e2e: src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
Style: ./build-support/hooks/pre-commit

Example output:

aurora update start devcluster/www-data/prod/hello 
./aurora/examples/jobs/updated_hello_world.aurora 
 INFO] Starting update for: hello
Job update has started. View your update progress at 
http://aurora.local:8081/scheduler/www-data/prod/hello/update/df5ba4d7-6a32-42ca-8453-1b172f61a23b
This job update will:
add instances: [2-3]
update instances: [0-1]


Thanks,

Mehrdad Nurolahzade

Reply via email to