> On May 23, 2016, 3:49 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java, line 
> > 120
> > <https://reviews.apache.org/r/47697/diff/2/?file=1391430#file1391430line120>
> >
> >     How about just using `Arg.create()` here, and only set it below if 
> > `LISTEN_IP.hasAppliedValue()` is `true`?
> >     
> >     If you make this change, please change the help for the arg to be 
> > something along the lines of, "...if not specified, the scheduler will 
> > listen on all interfaces."
> 
> Maxim Khutornenko wrote:
>     +1
> 
> Stephan Erb wrote:
>     Our arg parsing libary would then interpret the value as required, which 
> is a bit confusing. For example, see `db_max_active_connection_count` here 
> https://github.com/apache/aurora/blob/master/docs/reference/scheduler-configuration.md.

My +1 was on the `LISTEN_IP.hasAppliedValue()` argument. We should set the 
value only if it's non-null.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47697/#review134364
-----------------------------------------------------------


On May 23, 2016, 9 a.m., Chris Bannister wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47697/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 9 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Bugs: AURORA-572
>     https://issues.apache.org/jira/browse/AURORA-572
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add an -ip command line option which sets the IP that the Jetty server
> will listen on.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/JettyServerModule.java 
> 60667fc3639fdbdca5c258c9024cbeee30c6df7b 
> 
> Diff: https://reviews.apache.org/r/47697/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Bannister
> 
>

Reply via email to