> On May 23, 2016, 9:42 p.m., Stephan Erb wrote:
> > src/main/resources/scheduler/assets/js/controllers.js, line 168
> > <https://reviews.apache.org/r/47741/diff/1/?file=1391847#file1391847line168>
> >
> >     Any reason why this resource is lowercase but all others are uppercase?

These are actually Resource Consumption table column header mappings. 

I use `Disk` instead of `DISK` below in filter calls for consistency with 
`ResourceType` definitions, as `Disk` is not an acronym but rather a direct 
resource name.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47741/#review134443
-----------------------------------------------------------


On May 23, 2016, 9:26 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47741/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 9:26 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This cleans up UI from the old resource field usage.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/configSummary.html 
> 1af7511de0e8a143c8ea88377aad756b44e3ac30 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 84417ebeadfae57d55b9f12e8a985825bd620fc8 
>   src/main/resources/scheduler/assets/js/filters.js 
> ac48c7fc226236fff9d450490f262b10b75aee7d 
>   src/main/resources/scheduler/assets/js/services.js 
> d9ce52065f9573b0aa68a95da7da7c50fb14310a 
>   src/main/resources/scheduler/assets/schedulingDetail.html 
> eb88c1e6dec7a26643e8b13ffcf8e90df70a67f7 
> 
> Diff: https://reviews.apache.org/r/47741/diff/
> 
> 
> Testing
> -------
> 
> tested in vagrant
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to