> On May 23, 2016, 6 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 39
> > <https://reviews.apache.org/r/47440/diff/5/?file=1387602#file1387602line39>
> >
> >     Can your return this from `initializeConnection()` instead of keeping a 
> > global field?

Done.


> On May 23, 2016, 6 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 47
> > <https://reviews.apache.org/r/47440/diff/5/?file=1387602#file1387602line47>
> >
> >     This can be moved inside try.

Done.


> On May 23, 2016, 6 p.m., Maxim Khutornenko wrote:
> > src/main/java/org/apache/aurora/scheduler/events/Webhook.java, line 38
> > <https://reviews.apache.org/r/47440/diff/5/?file=1387602#file1387602line38>
> >
> >     Would it make sense to move this into WebhookInfo instead?

Done.


- Dmitriy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47440/#review134392
-----------------------------------------------------------


On May 25, 2016, 1:02 a.m., Dmitriy Shirchenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47440/
> -----------------------------------------------------------
> 
> (Updated May 25, 2016, 1:02 a.m.)
> 
> 
> Review request for Aurora, Maxim Khutornenko and Stephan Erb.
> 
> 
> Bugs: AURORA-1683
>     https://issues.apache.org/jira/browse/AURORA-1683
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Looking for some feedback whether I'm on the correct path in adding a 
> webhook. All comments are welcome!
> 
> 
> Diffs
> -----
> 
>   docs/reference/scheduler-configuration.md 
> f7d676d0ed6bc536f4341dbb9365cf50e8607efb 
>   examples/vagrant/upstart/aurora-scheduler.conf 
> 3d9e706de564df5e24cb34265bebc0db1cad11a0 
>   src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 
> 9ebfe230836e88a97bc60092373f72f176a8f6f2 
>   src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java 
> 2a4c0665e48d30e0655de00bd7f6f9b49f01eafc 
>   src/main/java/org/apache/aurora/scheduler/events/Webhook.java PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java 
> PRE-CREATION 
>   src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java 
> PRE-CREATION 
>   src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION 
>   src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47440/diff/
> 
> 
> Testing
> -------
> 
> Need to fix tests.
> 
> 
> Thanks,
> 
> Dmitriy Shirchenko
> 
>

Reply via email to