> On May 25, 2016, 6:19 a.m., Stephan Erb wrote:
> > src/main/resources/scheduler/assets/js/filters.js, lines 97-99
> > <https://reviews.apache.org/r/47741/diff/1/?file=1391848#file1391848line97>
> >
> >     In https://reviews.apache.org/r/47809/ you call this `"CPUs"` with a 
> > unit of `"core(s)"`. I don't really care how you call it, but would be 
> > great if it is consistent :-)

This is actually the "enum-like" mapping, which I feel should stay as CPUS to 
be more consistent with how mesos defines that resource name.

That said, I am changing the display part back to CPU to for consistency with 
the client.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47741/#review134710
-----------------------------------------------------------


On May 23, 2016, 9:26 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47741/
> -----------------------------------------------------------
> 
> (Updated May 23, 2016, 9:26 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This cleans up UI from the old resource field usage.
> 
> 
> Diffs
> -----
> 
>   src/main/resources/scheduler/assets/configSummary.html 
> 1af7511de0e8a143c8ea88377aad756b44e3ac30 
>   src/main/resources/scheduler/assets/js/controllers.js 
> 84417ebeadfae57d55b9f12e8a985825bd620fc8 
>   src/main/resources/scheduler/assets/js/filters.js 
> ac48c7fc226236fff9d450490f262b10b75aee7d 
>   src/main/resources/scheduler/assets/js/services.js 
> d9ce52065f9573b0aa68a95da7da7c50fb14310a 
>   src/main/resources/scheduler/assets/schedulingDetail.html 
> eb88c1e6dec7a26643e8b13ffcf8e90df70a67f7 
> 
> Diff: https://reviews.apache.org/r/47741/diff/
> 
> 
> Testing
> -------
> 
> tested in vagrant
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to