----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47440/#review135233 -----------------------------------------------------------
Repeating from my previous review: Would be great if you could add * an entry to the release notes * a minimal docs/features/webhooks.md that shows a valid webhook config and how a dispatched event would look like. src/main/java/org/apache/aurora/scheduler/events/Webhook.java (line 72) <https://reviews.apache.org/r/47440/#comment200262> This will fail with a `NullPointerException` when `initializeConnection()` returns `None`. Same applies to other places in the content of the try block. src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java (line 71) <https://reviews.apache.org/r/47440/#comment200265> Is it intentional that you use multiple names for the timeout here? (`connectTimeout` vs `timeoutMsec`) - Stephan Erb On May 27, 2016, 12:29 a.m., Dmitriy Shirchenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47440/ > ----------------------------------------------------------- > > (Updated May 27, 2016, 12:29 a.m.) > > > Review request for Aurora, Maxim Khutornenko and Stephan Erb. > > > Bugs: AURORA-1683 > https://issues.apache.org/jira/browse/AURORA-1683 > > > Repository: aurora > > > Description > ------- > > Looking for some feedback whether I'm on the correct path in adding a > webhook. All comments are welcome! > > > Diffs > ----- > > docs/reference/scheduler-configuration.md > f7d676d0ed6bc536f4341dbb9365cf50e8607efb > src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java > 9ebfe230836e88a97bc60092373f72f176a8f6f2 > src/main/java/org/apache/aurora/scheduler/events/PubsubEvent.java > 2a4c0665e48d30e0655de00bd7f6f9b49f01eafc > src/main/java/org/apache/aurora/scheduler/events/Webhook.java PRE-CREATION > src/main/java/org/apache/aurora/scheduler/events/WebhookInfo.java > PRE-CREATION > src/main/java/org/apache/aurora/scheduler/events/WebhookModule.java > PRE-CREATION > src/main/resources/org/apache/aurora/scheduler/webhook.json PRE-CREATION > src/test/java/org/apache/aurora/scheduler/events/WebhookTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/47440/diff/ > > > Testing > ------- > > Need to fix tests. > > > Thanks, > > Dmitriy Shirchenko > >
