----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48082/#review136092 -----------------------------------------------------------
Looks good to me in general. Mostly nits below... src/main/java/org/apache/aurora/scheduler/TierManager.java (lines 46 - 48) <https://reviews.apache.org/r/48082/#comment201085> Add javadoc for both of these. src/main/java/org/apache/aurora/scheduler/TierManager.java (lines 60 - 61) <https://reviews.apache.org/r/48082/#comment201080> Style nit, our continuation indent style is: public TierConfig( @JsonProperty("...") String defaultTier, ...) { // first line of method body here, note blank line above. src/main/java/org/apache/aurora/scheduler/TierManager.java (line 62) <https://reviews.apache.org/r/48082/#comment201084> nit: s/Default/Default tier src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java (lines 381 - 385) <https://reviews.apache.org/r/48082/#comment201089> `Tier` should be generated with a constructor that takes all of these args? Can we just do... TierInfo tierInfo = entry.getValue(); return new Tier(entry.getKey(), tierInfo.isPreemptible(), tierInfo.isRevocable()); src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java (lines 391 - 392) <https://reviews.apache.org/r/48082/#comment201087> Should fit on one line? - Joshua Cohen On May 31, 2016, 7:02 p.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48082/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 7:02 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Repository: aurora > > > Description > ------- > > AURORA-1624 Make 'tier' required and remove support for 'production' flag in > Job configuration - New thrift API for retrieving tier configuration > > > Diffs > ----- > > api/src/main/thrift/org/apache/aurora/gen/api.thrift > ed94f249d85ac0e438213924c777cf7c029a119a > src/main/java/org/apache/aurora/scheduler/TierManager.java > b96189be0ada1623665c2bff2550c1d72d7bc3dd > src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java > e431b58c933886f46c095240704d3eb0ceea2d80 > src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java > 0d4f04403ec20c21b7cfacd706557cd191579f0a > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > 4d032b96d55dd0b92fab338220e66628e38cbb11 > src/main/resources/org/apache/aurora/scheduler/tiers.json > f724c5ad03a1315bc55dac35d98fdef45625e017 > src/test/java/org/apache/aurora/scheduler/TierManagerTest.java > 95174bb7454a9e7c075ebaa6a4f84bf55fbc2652 > src/test/java/org/apache/aurora/scheduler/TierModuleTest.java > 6b4e7a0d5e64d0632c66273ad516f737b2ef4a92 > > src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java > 2122f744089adaee24328a634a2f786d1ef9720f > > Diff: https://reviews.apache.org/r/48082/diff/ > > > Testing > ------- > > Manual/Explorative: Invoked from CLI-side to see if the new API call works as > intended > Integration: ./build-support/jenkins/build.sh > E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > > Thanks, > > Mehrdad Nurolahzade > >
