-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48082/#review136297
-----------------------------------------------------------




api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 246)
<https://reviews.apache.org/r/48082/#comment201315>

    Please, have a ticket filed to follow up with removal and mention it here 
with a TODO. See above for a pattern.



api/src/main/thrift/org/apache/aurora/gen/api.thrift (lines 912 - 919)
<https://reviews.apache.org/r/48082/#comment201322>

    This would unnecessarily bind us to the `TierInfo` schema and make it 
harder to evolve tier defintions. I don't expect any clients to take advantage 
of the structured `Tier` data beyond the interim migration phase (e.g. 
populating `production` flag off of default tier). 
    
    How about generalizing `Tier` to have a map of values instead? E.g.:
    ```
    struct TierConfig {
      1: string name
      2: map<string, string> settings
    }
    ```



api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 922)
<https://reviews.apache.org/r/48082/#comment201323>

    Suggest renaming to follow after the established patter of RPC name + 
`Result`. E.g.: `GetTierConfigsResult`?



api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 924)
<https://reviews.apache.org/r/48082/#comment201326>

    This should probably be `defaultTierName`.



api/src/main/thrift/org/apache/aurora/gen/api.thrift (line 1023)
<https://reviews.apache.org/r/48082/#comment201325>

    Rename to `getTierConfigs`?


- Maxim Khutornenko


On May 31, 2016, 7:02 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48082/
> -----------------------------------------------------------
> 
> (Updated May 31, 2016, 7:02 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1624 Make 'tier' required and remove support for 'production' flag in 
> Job configuration - New thrift API for retrieving tier configuration
> 
> 
> Diffs
> -----
> 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> ed94f249d85ac0e438213924c777cf7c029a119a 
>   src/main/java/org/apache/aurora/scheduler/TierManager.java 
> b96189be0ada1623665c2bff2550c1d72d7bc3dd 
>   src/main/java/org/apache/aurora/scheduler/base/TaskTestUtil.java 
> e431b58c933886f46c095240704d3eb0ceea2d80 
>   src/main/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImpl.java 
> 0d4f04403ec20c21b7cfacd706557cd191579f0a 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  4d032b96d55dd0b92fab338220e66628e38cbb11 
>   src/main/resources/org/apache/aurora/scheduler/tiers.json 
> f724c5ad03a1315bc55dac35d98fdef45625e017 
>   src/test/java/org/apache/aurora/scheduler/TierManagerTest.java 
> 95174bb7454a9e7c075ebaa6a4f84bf55fbc2652 
>   src/test/java/org/apache/aurora/scheduler/TierModuleTest.java 
> 6b4e7a0d5e64d0632c66273ad516f737b2ef4a92 
>   
> src/test/java/org/apache/aurora/scheduler/thrift/ReadOnlySchedulerImplTest.java
>  2122f744089adaee24328a634a2f786d1ef9720f 
> 
> Diff: https://reviews.apache.org/r/48082/diff/
> 
> 
> Testing
> -------
> 
> Manual/Explorative: Invoked from CLI-side to see if the new API call works as 
> intended
> Integration: ./build-support/jenkins/build.sh
> E2E: ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Reply via email to