> On May 28, 2016, 9:35 p.m., Stephan Erb wrote:
> > The refactoring itself looks good. However, I am not sure if we should 
> > really opt for the metric name change. It will break external statistic 
> > scrapers without a great benefit for us.

Correct, this will require adjusting scheduler metric consumers to work with 
MBs rather than GBs. I was under assumption that consistency across the entire 
platform is worth this minor disruption on the metrics side. It may feel forced 
to special case RAM and DISK resources just for the sake of 
reporting/monitoring yet deal with direct (MB) units everywhere else in the 
system. Given that scheduler metrics are usually internal to cluster operation 
(vs. job SLA stats for example), I feel this change is acceptable. Do you feel 
otherwise?


> On May 28, 2016, 9:35 p.m., Stephan Erb wrote:
> > src/main/java/org/apache/aurora/scheduler/http/Utilization.java, lines 
> > 127-137
> > <https://reviews.apache.org/r/47998/diff/1/?file=1400078#file1400078line127>
> >
> >     I am confused. Where are those used?

These are called by string template processing in utilization.st to populate 
resource fields


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47998/#review135394
-----------------------------------------------------------


On May 28, 2016, 12:43 a.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47998/
> -----------------------------------------------------------
> 
> (Updated May 28, 2016, 12:43 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The side-effect of this refactoring is converting from GB to MB in RAM/Disk 
> metrics. This is consistent with the rest of the system and does not require 
> an additional complexity of some sort of a unit converter in `ResourceType`. 
> All scheduler consumed resources stats will change as:
> _cpu -> _cpu_cores
> _ram_gb -> _ram_mb
> _disk_gb -> _disk_gb
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/http/Utilization.java 
> 4a609e368a451f3f3b0b0fde9770aed213325f0d 
>   src/main/java/org/apache/aurora/scheduler/quota/QuotaManager.java 
> 612525c32654c60962a0319a66905c325a0d5a1c 
>   src/main/java/org/apache/aurora/scheduler/resources/ResourceType.java 
> 6a4f110ff461876ca14c24947f4813d5f2a0dae5 
>   src/main/java/org/apache/aurora/scheduler/stats/ResourceCounter.java 
> 5231e9f547004534c027289111544e707a64e6ec 
>   src/main/java/org/apache/aurora/scheduler/stats/TaskStatCalculator.java 
> 2511a39fecadc775aee574515f52ac49ba137855 
>   src/main/resources/org/apache/aurora/scheduler/http/utilization.st 
> ae497a7c2b5c76a74e5b7ed07b98286a2542aa12 
>   src/test/java/org/apache/aurora/scheduler/resources/ResourceTypeTest.java 
> 7ba5567910c46127dab546ad3ad3bb70f562ec2b 
>   src/test/java/org/apache/aurora/scheduler/stats/ResourceCounterTest.java 
> fd4b434aef9d18c94eac51c6ea58512df1f07346 
> 
> Diff: https://reviews.apache.org/r/47998/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Reply via email to