-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48360/#review136552
-----------------------------------------------------------



Thanks for adding this, great to get it documented!

Would you mind cleaning up the inline double spaces and the trailing whitespace 
that reviewboard is showing (the red in the middle/at the end of some lines).


docs/operations/configuration.md (lines 147 - 148)
<https://reviews.apache.org/r/48360/#comment201628>

    "the scheduler can be configured to utilize a custom executor by specifying 
the `-custom_executor_config` flag.



docs/operations/configuration.md (lines 151 - 152)
<https://reviews.apache.org/r/48360/#comment201629>

    "The configuration file must be valid JSON and contain, at minimum, the 
name, command and resources fields."



docs/operations/configuration.md (lines 154 - 162)
<https://reviews.apache.org/r/48360/#comment201633>

    Rather than explaining this in conversational English, it might be easier 
to understand if we just have a table that lists the allowed attributes for 
each property in the config file?
    
    Something like...
    
      ### command
    
      **Property**             | **Description**
      -------------------      | ---------------------------------
      **value** (required)     | The command to execute.
      **arguments** (optional) | A list of arguments to pass to the command.
      **uris** (optional)      | Resources to download into the task sandbox.
      
      ### volume_mounts
      ...
    
    What do you think?



docs/operations/configuration.md (line 217)
<https://reviews.apache.org/r/48360/#comment201625>

    s/nformation/information



docs/operations/configuration.md (line 218)
<https://reviews.apache.org/r/48360/#comment201626>

    move this up to the previous line?


- Joshua Cohen


On June 7, 2016, 9 p.m., Renan DelValle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48360/
> -----------------------------------------------------------
> 
> (Updated June 7, 2016, 9 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Bill Farner.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Adding documentation for using a custom executor configuration.
> 
> 
> Diffs
> -----
> 
>   docs/operations/configuration.md 65cf64a713db87996b92bf8305d1fc565163f106 
> 
> Diff: https://reviews.apache.org/r/48360/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Reply via email to