-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49399/#review140065
-----------------------------------------------------------




src/main/python/apache/thermos/core/runner.py (line 747)
<https://reviews.apache.org/r/49399/#comment205381>

    NB: The trailing comma here on the LHS formed a 1-tuple leading to the 
initial bug report (wrong type).


- John Sirois


On June 29, 2016, 4:53 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49399/
> -----------------------------------------------------------
> 
> (Updated June 29, 2016, 4:53 p.m.)
> 
> 
> Review request for Aurora, George Sirois, Martin Hrabovcin, and Stephan Erb.
> 
> 
> Bugs: AURORA-1724
>     https://issues.apache.org/jira/browse/AURORA-1724
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Previously flagged configuration of Process logging mode would
> blow up and claimed defaulting of the rotation policy did not
> occur.
> 
>  docs/operations/configuration.md                                    |   9 +-
>  docs/reference/configuration.md                                     |  33 
> ++++----
>  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py |  21 
> ++---
>  src/main/python/apache/thermos/core/runner.py                       |  40 
> ++++++---
>  src/main/python/apache/thermos/testing/runner.py                    |  16 
> ++--
>  src/test/python/apache/thermos/core/BUILD                           |   2 +
>  src/test/python/apache/thermos/core/test_runner_log_config.py       | 230 
> ++++++++++++++++++++++++++++++++++++++++++++++++++
>  7 files changed, 293 insertions(+), 58 deletions(-)
> 
> 
> Diffs
> -----
> 
>   docs/operations/configuration.md e332f864aeb25790f860bc1961a7a2c49b29004e 
>   docs/reference/configuration.md c4b1d387435e4b8fd59a296bd5d6d203bb50cbde 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 203fc47d74840889a1192dc867fef5584b704685 
>   src/main/python/apache/thermos/core/runner.py 
> 3ebf86ebd12ed3b68f543d4b9a45615e4681ba7f 
>   src/main/python/apache/thermos/testing/runner.py 
> 8b6ba730acedf284a61e4bde60ab480950f92ede 
>   src/test/python/apache/thermos/core/BUILD 
> acfb79b6c411744be7f8b3bb364f0c8d049f1694 
>   src/test/python/apache/thermos/core/test_runner_log_config.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49399/diff/
> 
> 
> Testing
> -------
> 
> Manually tested the cases in
>   https://issues.apache.org/jira/browse/AURORA-1724.
> 
> Also ran the following green locally:
> ```
> ./pants test src/test/python/apache/thermos/core
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> ```
> 
> Doc edits are rendered here:
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/reference/configuration.md#logger
>   
> https://github.com/jsirois/aurora/blob/jsirois/issues/AURORA-1724/docs/operations/configuration.md#process-logs
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to