-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49512/
-----------------------------------------------------------

Review request for Aurora.


Repository: aurora


Description
-------

I'd like to get feedback on this patch.

Thermos currently monitors only sandbox directory but when running with Docker 
containerizer process can write data to whole container filesystem. This patch 
gives option to monitor whole docker container filesystem.

Behavior is unchanged if new flag isn't provided.


Diffs
-----

  examples/jobs/docker/hello_docker.aurora 
47adb3932323120e62649f43353719b76c48a963 
  src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
203fc47d74840889a1192dc867fef5584b704685 
  src/main/python/apache/aurora/executor/common/resource_manager.py 
b7dc40d8973ec2e5998ab4f6ff988051a70bb1ab 
  src/main/python/apache/thermos/monitoring/disk.py 
52c5d74fd70b5942ea3ef5101ba3f27bfc98fc21 
  src/main/python/apache/thermos/monitoring/resource.py 
53d0ff1a71c27f053c59acca556c35d1e5ac91f0 
  
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py
 fe74bd1d36666ecd89fca1b5b2251202cbbc0f24 
  src/test/python/apache/thermos/monitoring/test_disk.py 
e57467c61d94d67e6cf6b766c062588235b4b235 

Diff: https://reviews.apache.org/r/49512/diff/


Testing
-------

e2e testing
unit tests
manual testing in Vagrant dev box and on custom dev cluster with option enabled.


Thanks,

Martin Hrabovcin

Reply via email to