-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49578/
-----------------------------------------------------------

Review request for Aurora, Stephan Erb, Bill Farner, and Zameer Manji.


Bugs: AURORA-1729
    https://issues.apache.org/jira/browse/AURORA-1729


Repository: aurora


Description
-------

Previously these lifecycles were modeled as independent when, in fact,
a `CuratorFramework`'s clients must be closed befor it is closed to
prevent errors in the clients from attempting to use a closed
`CuratorFramework`.

The proof that closing was always safe already existed in
`CuratorServiceGroupMonitorTest::testExceptionalLifecycle`, but this
safety is now documented and more explicitly tested.

 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
  | 15 ++++++++++++++-
 
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
     | 10 ++++++++++
 
src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java
 | 10 +++++++++-
 3 files changed, 33 insertions(+), 2 deletions(-)


Diffs
-----

  
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceDiscoveryModule.java
 2656662837ecfdd2addb0d67dd28e54ed6d05330 
  
src/main/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitor.java
 9d8b7bdd49b2e0f907f532825fd79f9e8854a650 
  
src/test/java/org/apache/aurora/scheduler/discovery/CuratorServiceGroupMonitorTest.java
 16692056ffb97e6bfcc8c80c8f4faecc7ae16c62 

Diff: https://reviews.apache.org/r/49578/diff/


Testing
-------

Locally green:
```
./gradlew -Pq clean build
./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
```


Thanks,

John Sirois

Reply via email to