----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49593/#review140670 -----------------------------------------------------------
Ship it! Master (311b892) is green with this patch. ./build-support/jenkins/build.sh I will refresh this build result if you post a review containing "@ReviewBot retry" - Aurora ReviewBot On July 4, 2016, 2:52 p.m., John Sirois wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49593/ > ----------------------------------------------------------- > > (Updated July 4, 2016, 2:52 p.m.) > > > Review request for Aurora and Stephan Erb. > > > Bugs: AURORA-1620 > https://issues.apache.org/jira/browse/AURORA-1620 > > > Repository: aurora > > > Description > ------- > > This picks up a fix for creating wheels for aurora components. > > Release notes here: > https://pypi.python.org/pypi/pantsbuild.pants/1.1.0-pre6 > > pants.ini | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > > Diffs > ----- > > pants.ini 1043275791b537941ec3805611aa7aad05e22403 > > Diff: https://reviews.apache.org/r/49593/diff/ > > > Testing > ------- > > Manual testing locally using `./pants setup-py` directly and using > sdists generated from `./build-support/release/make-python-sdists` > for manual conversion: > ``` > $ rm -rf dist/ > > $ ./pants setup-py --run=bdist_wheel src/main/python/apache/aurora/client > $ unzip -qc > dist/apache.aurora.client-0.16.0-SNAPSHOT/dist/apache.aurora.client-0.16.0_SNAPSHOT-py2-none-any.whl > apache/aurora/client/cli/.auroraversion > 0.16.0-SNAPSHOT > > $ ./build-support/release/make-python-sdists > $ mkdir /tmp/convert > $ tar -xz -C /tmp/convert/ -f dist/apache.aurora.client-0.16.0-SNAPSHOT.tar.gz > $ pyenv activate wheel > $ cd /tmp/convert/apache.aurora.client-0.16.0-SNAPSHOT/ > $ python setup.py bdist_wheel > $ unzip -qc dist/apache.aurora.client-0.16.0_SNAPSHOT-py2-none-any.whl > apache/aurora/client/cli/.auroraversion > 0.16.0-SNAPSHOT > ``` > > Also green locally: > ``` > $ ./build-support/jenkins/build.sh > $ ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > ``` > > > Thanks, > > John Sirois > >
