> On July 4, 2016, 9:36 a.m., John Sirois wrote:
> > build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch,
> >  line 8
> > <https://reviews.apache.org/r/49528/diff/1/?file=1435189#file1435189line8>
> >
> >     This is a bug - should be `if (!first) {`.  We don't hit this bug since 
> > we don't declare thrift service exceptions, but I'll circle back with a fix 
> > for sanity sake.

Fix here: https://reviews.apache.org/r/49595/


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49528/#review140671
-----------------------------------------------------------


On July 1, 2016, 1:28 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49528/
> -----------------------------------------------------------
> 
> (Updated July 1, 2016, 1:28 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1727
>     https://issues.apache.org/jira/browse/AURORA-1727
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> This also patches the thrift compiler Makefile.in to eliminate all
> generators not used by Aurora to both work around their modern gcc
> compiler errors and speed up the thrift compiler build.
> 
>  build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch              
>         | 376 ++++++++++++++++++++++++++++++++++++++++++++++++++
>  
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
>  |  14 ++
>  build-support/thrift/Makefile                                                
>         |   2 +
>  3 files changed, 392 insertions(+)
> 
> 
> Diffs
> -----
> 
>   build-support/thrift/AURORA-1727.compiler.cpp.Makefile.in.patch 
> PRE-CREATION 
>   
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
>  PRE-CREATION 
>   build-support/thrift/Makefile c28f4146b4874fe5faf6dbd872a692d39816d4bb 
> 
> Diff: https://reviews.apache.org/r/49528/diff/
> 
> 
> Testing
> -------
> 
> Locally green under gcc 6.1.1 20160602 using:
> ```
> git clean -fdx build-support/thrift/
> ./gradlew -Pq clean build
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to