-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49595/#review140675
-----------------------------------------------------------


Ship it!




Master (43db929) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot 
retry"

- Aurora ReviewBot


On July 4, 2016, 3:45 p.m., John Sirois wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49595/
> -----------------------------------------------------------
> 
> (Updated July 4, 2016, 3:45 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Bugs: AURORA-1727
>     https://issues.apache.org/jira/browse/AURORA-1727
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> The initial patch inverted logic for emitting `else if` clauses.
> 
>  
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
>  | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> 
> Diffs
> -----
> 
>   
> build-support/thrift/AURORA-1727.compiler.cpp.src.generate.t_java_generator.cc.patch
>  c7ad4bb90c8e0124998f63cbcae8b0fec61f32ba 
> 
> Diff: https://reviews.apache.org/r/49595/diff/
> 
> 
> Testing
> -------
> 
> Locally re-bootstrapped:
> ```
> $ cd build-support/thrift
> $ git clean -fdx .
> $ make
> $ ./thriftw 0.9.1 -version
> Thrift version 0.9.1
> ```
> 
> 
> Thanks,
> 
> John Sirois
> 
>

Reply via email to