-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49868/#review141623
-----------------------------------------------------------


Ship it!




LGTM.  I stole your edits and applied them to the canonical bootstrap script 
which the Aurora `./pants` script is mod the extra license header: 
https://github.com/pantsbuild/setup/commit/31976dcc75d1facc1fd5496c878684b8b955f1cc

- John Sirois


On July 10, 2016, 11:38 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49868/
> -----------------------------------------------------------
> 
> (Updated July 10, 2016, 11:38 a.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Bugs: AURORA-1717
>     https://issues.apache.org/jira/browse/AURORA-1717
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Update virtualenv to 15.0.2. This includes updates to `pip==8.1.2`, 
> `setuptools==21.2.1`, and `wheel==0.29.0`. Full changelog: 
> https://virtualenv.pypa.io/en/stable/changes/
> 
> Additional changes to our scripts:
> 
> * abort the pants bootstrapping script if an error is encountered
> * switch to download URLs that are working for the latest virtualenv version
> * disable the recently added auto-updating of pip and setuptools so that we 
> gain a reproducable build environment
> 
> 
> Diffs
> -----
> 
>   build-support/virtualenv 03c14323e14d2a3923e080efc947107b9b8a3a16 
>   pants a11588a02d9b471b600a5095476caa5ae8eb8161 
> 
> Diff: https://reviews.apache.org/r/49868/diff/
> 
> 
> Testing
> -------
> 
> rm -rf ~/.cache/pants/
> git clean -fxd
> ./pants test.pytest src/{main,test}/python::
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to