> On July 10, 2016, 3:35 p.m., John Sirois wrote:
> > I'm not sure this is directly relevant to the problem at hand.  Pants 
> > bootstraps fine, is the thermos integration tests that pants runs (must be 
> > bootstrapped via pip to do so), that have a `./pants` subprocess call fail.
> > You mentined a too-long shebang, which either should cause every CI run to 
> > fail or else it means the shebang length is configurable and configured 
> > differently on various Apache build farm Jenkins slaves ... which is likely.
> > 
> > I'm digging a bit to see if I can confirm more details.

The shebangs from the zips I captured on 7/8 were in fact 128 characters long, 
so this change is needed on machines with that limit.  I still don;t have a 
handle on which machines in the Jenkins slave fleet that we run on have this 
limit, but good change regardless.


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49868/#review141622
-----------------------------------------------------------


On July 10, 2016, 11:38 a.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49868/
> -----------------------------------------------------------
> 
> (Updated July 10, 2016, 11:38 a.m.)
> 
> 
> Review request for Aurora and John Sirois.
> 
> 
> Bugs: AURORA-1717
>     https://issues.apache.org/jira/browse/AURORA-1717
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Update virtualenv to 15.0.2. This includes updates to `pip==8.1.2`, 
> `setuptools==21.2.1`, and `wheel==0.29.0`. Full changelog: 
> https://virtualenv.pypa.io/en/stable/changes/
> 
> Additional changes to our scripts:
> 
> * abort the pants bootstrapping script if an error is encountered
> * switch to download URLs that are working for the latest virtualenv version
> * disable the recently added auto-updating of pip and setuptools so that we 
> gain a reproducable build environment
> 
> 
> Diffs
> -----
> 
>   build-support/virtualenv 03c14323e14d2a3923e080efc947107b9b8a3a16 
>   pants a11588a02d9b471b600a5095476caa5ae8eb8161 
> 
> Diff: https://reviews.apache.org/r/49868/diff/
> 
> 
> Testing
> -------
> 
> rm -rf ~/.cache/pants/
> git clean -fxd
> ./pants test.pytest src/{main,test}/python::
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to