> On July 19, 2016, 12:17 p.m., Stephan Erb wrote:
> > src/test/java/org/apache/aurora/scheduler/http/OffersTest.java, lines 
> > 143-149
> > <https://reviews.apache.org/r/50052/diff/3/?file=1447038#file1447038line143>
> >
> >     The test is very closly following implementation of the code we want to 
> > test. 
> >     
> >     Even though it comes with boilerplate, I believe we gain clarity if you 
> > compare the request result to a plain text json that we keep as a text 
> > fixture, rather than parsing the json back into an offer.
> >     
> >     I don't have a really strong opinion here, especially given that the 
> > class was untested before. Feel free to ignore if you see this otherwise.

Yeah, I thought of that too. However, now that we are rendering JSON directly 
from Mesos protobuf structures, the generated JSON can potentially change every 
time we upgrade the Mesos library dependency, hence a test relying on text 
fixtures would be fragile and can potentially break each time (which is no big 
deal, we can have the text fixture modified according to the latest protobuf 
updates).


- Mehrdad


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50052/#review142805
-----------------------------------------------------------


On July 18, 2016, 7:12 p.m., Mehrdad Nurolahzade wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50052/
> -----------------------------------------------------------
> 
> (Updated July 18, 2016, 7:12 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Stephan Erb.
> 
> 
> Bugs: AURORA-1736
>     https://issues.apache.org/jira/browse/AURORA-1736
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> AURORA-1736 Display reservations and persistent volumes in /offers debug http 
> endpoint
> 
> 
> Diffs
> -----
> 
>   config/legacy_untested_classes.txt 1ea2183ab20cc5c6bca147bcea4e5c708d576b62 
>   src/main/java/org/apache/aurora/scheduler/http/Offers.java 
> 80f082410896a50d86c7886736caf79581f5051c 
>   src/test/java/org/apache/aurora/scheduler/http/OffersTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50052/diff/
> 
> 
> Testing
> -------
> 
> Manual, Jenkins, and end_to_end
> 
> 
> File Attachments
> ----------------
> 
> CURRENT
>   
> https://reviews.apache.org/media/uploaded/files/2016/07/18/1de4c357-c932-4c84-962f-4209a5b679bc__offers-old.json
> NEW
>   
> https://reviews.apache.org/media/uploaded/files/2016/07/19/799bcd1f-f9c8-4b6e-bbaa-ce8022b1dac1__offers-new.json
> 
> 
> Thanks,
> 
> Mehrdad Nurolahzade
> 
>

Reply via email to