----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/ -----------------------------------------------------------
(Updated July 19, 2016, 9:38 p.m.) Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Bill Farner, and Zameer Manji. Bugs: AURORA-1721 https://issues.apache.org/jira/browse/AURORA-1721 Repository: aurora Description (updated) ------- Add rollback functionality to the scheduler I talked to Zameer and it seems like there is another less invasive to update job's state machine approach. I'll update the review shortly. We were thinking about creating a new JobUpdate and applying previous desired state as new update job's initial state. That would not work because there are multiple initial states and a single desired state. So sticking to this design for now. Diffs ----- api/src/main/thrift/org/apache/aurora/gen/api.thrift 1d66208490aff6ea8af4c737845fa2cf13617529 src/main/java/org/apache/aurora/scheduler/storage/JobUpdateStore.java 52c3c6618a3cf1009435ca8a9cece36365913e55 src/main/java/org/apache/aurora/scheduler/storage/db/DbJobUpdateStore.java d2673e6b328cb1e249fbe91d18e0d9e935636eaa src/main/java/org/apache/aurora/scheduler/storage/log/WriteAheadStorage.java d0de063fd78e6c4f62fae4a598d1d22f9775772d src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java b534abf95bab6e1657e3ef993cf34c0d6ec460be src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java 9243c92b11040b68ed6014b3991db69fc08bcddf src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java f8357c46df1b025bf4e38a7ce1cb1c13a50c39f9 src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java 364c5c753f884a2d89e27802d7bbf3b2b6d3a08e src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java 7ab739a4dfa292895ad6ba8849e65f5c45ce9770 src/main/python/apache/aurora/client/api/__init__.py 68baf8fdb90cd26100159401c46c9963c24332b3 src/main/python/apache/aurora/client/cli/update.py bb526f7bf94d7bfe02fe2786493c85be1bfeb86f src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java 8d78bae2cbf365a5359d88c0e996b3972a21e50e src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java e157c0dfde5efc418448e138aa008ade742fe816 src/test/python/apache/aurora/client/api/test_scheduler_client.py afbd385b7eda64cb1f7d118b695e65e4045eac6c Diff: https://reviews.apache.org/r/50168/diff/ Testing ------- Thanks, Igor Morozov