> On July 19, 2016, 3:27 p.m., Stephan Erb wrote: > > src/main/python/apache/aurora/client/cli/context.py, line 143 > > <https://reviews.apache.org/r/49048/diff/7/?file=1440197#file1440197line143> > > > > Side stepping the `get_config` factory and re-creating the > > `AnnotatedAuroraConfig` does not seem optimal in my eyes. > > > > Have you considered using Aurora's binding helper concept instead? Idea > > would be: > > > > * change the default of tier from `None` to `{{aurora.default_tier}}` > > (or something similar) > > * register a binding helper > > https://github.com/apache/aurora/blob/528198ecbf4adde22988f6073b043e3da049486d/src/main/python/apache/aurora/client/binding_helper.py#L33 > > > > * let the helper automatically resolve the binding via a call to the > > scheduler whenever the user has not set a custom tier > > > > Backfilling of the production flag could be moved to the scheduler side.
Thanks for pointing out binding helpers, did not know about them. The backfilling of production/tier attributes is already happening on the scheduler side. We did that as part of the same ticket and it has already been merged to master, see [rb 48559](https://reviews.apache.org/r/48559). To idea here is to have the backfill logic repeated on the client side so that if the new client is used against the old scheduler it would still correctly backfill tier and production settings. Perhaps we can throw away this client side backfilling logic in the future and allow it to be done entirely on the scheduler side. - Mehrdad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49048/#review142828 ----------------------------------------------------------- On July 8, 2016, 4:15 p.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49048/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 4:15 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1710 > https://issues.apache.org/jira/browse/AURORA-1710 > > > Repository: aurora > > > Description > ------- > > AURORA-1710 Make 'tier' required and remove support for 'production' flag in > Job configuration - CLI changes > > > Diffs > ----- > > RELEASE-NOTES.md 29d224d5596eb060356f1343cf347db79b1ad687 > src/main/python/apache/aurora/client/api/__init__.py > 68baf8fdb90cd26100159401c46c9963c24332b3 > src/main/python/apache/aurora/client/cli/context.py > 9b1511801d031ff48b81c25688a55cb586b8ac66 > src/main/python/apache/aurora/client/config.py > 2fc12559016d406c347adb416a5166cca31c961e > src/test/python/apache/aurora/client/cli/test_command_hooks.py > 2130f1fa71be02a004cdf8e476a270c81a7105d3 > src/test/python/apache/aurora/client/cli/test_context.py > 204ca092adad8bf43c5032a02f61bf303fb0b2fc > src/test/python/apache/aurora/client/cli/test_create.py > 8c27e2b340bb0a5fb5bcb44ef94d433e7f92c76c > src/test/python/apache/aurora/client/cli/test_cron.py > f3c522ed94a2d774865811ceb546bf9df083c14f > src/test/python/apache/aurora/client/cli/test_plugins.py > a545fece5e2b3e0017a61e1be9ac478372b1f34d > src/test/python/apache/aurora/client/cli/test_restart.py > 967d560e5c7eb0ed85b215fb11d9751b8666acb5 > src/test/python/apache/aurora/client/cli/util.py > 7b4558ec7f0fb0fd2902591bc6a90dc15051dd6e > src/test/python/apache/aurora/client/test_config.py > b1a3c1865819899ef19173be0f861783a2631d0a > > Diff: https://reviews.apache.org/r/49048/diff/ > > > Testing > ------- > > ``` > ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh > > *** OK (All tests passed) *** > > mesos-master start/running, process 26868 > + RETCODE=0 > + restore_netrc > + mv /home/vagrant/.netrc.bak /home/vagrant/.netrc > + true > Connection to 127.0.0.1 closed. > > real 19m46.324s > user 0m1.496s > sys 0m0.774s > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
