> On July 29, 2016, 2:03 p.m., Joshua Cohen wrote: > > src/main/python/apache/aurora/client/config.py, line 138 > > <https://reviews.apache.org/r/50432/diff/1/?file=1452163#file1452163line138> > > > > Isn't this undoing the bug fix to compare w/ `Empty` instead of `None`? > > Mehrdad Nurolahzade wrote: > You are right, not sure why this is happening. > > But that's not part of my new change-set, should be review board mix up!
I'll create a new RB. - Mehrdad ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50432/#review144191 ----------------------------------------------------------- On July 29, 2016, 2 p.m., Mehrdad Nurolahzade wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50432/ > ----------------------------------------------------------- > > (Updated July 29, 2016, 2 p.m.) > > > Review request for Aurora, Joshua Cohen and Maxim Khutornenko. > > > Bugs: AURORA-1741 > https://issues.apache.org/jira/browse/AURORA-1741 > > > Repository: aurora > > > Description > ------- > > AURORA-1741 Fix pystachio binding bug introduced by AURORA-1710 > > > Diffs > ----- > > src/test/python/apache/aurora/client/test_config.py > 4742fa28e3156e5b20791b80f2db8392f7f2f4bf > > Diff: https://reviews.apache.org/r/50432/diff/ > > > Testing > ------- > > ``` > ./build-support/jenkins/build.sh > > ``` > > > Thanks, > > Mehrdad Nurolahzade > >
