-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50819/#review144825
-----------------------------------------------------------



@ReviewBot retry

- David McLaughlin


On Aug. 4, 2016, 9:10 p.m., David McLaughlin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50819/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2016, 9:10 p.m.)
> 
> 
> Review request for Aurora and Mehrdad Nurolahzade.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Use update_job instead of creating new config object when modifying. This 
> avoids losing any state (e.g. metadata) attached to the config.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/client/cli/context.py 
> 7bbfb5e815b2408b8ddaaeeb9911a5bd1b019a27 
> 
> Diff: https://reviews.apache.org/r/50819/diff/
> 
> 
> Testing
> -------
> 
> $ ./pants test.pytest src/test/python/apache/aurora/client::
> 
> 14:07:19 00:00 [main]
>                (To run a reporting server: ./pants server)
> 14:07:19 00:00   [setup]
> 14:07:19 00:00     [parse]
>                Executing tasks in goals: test
> 14:07:19 00:00   [test]
> 14:07:19 00:00     [test-prep-command]
> 14:07:19 00:00     [test]
> 14:07:19 00:00     [pytest]
> 14:07:19 00:00       [run]
>                      
> 14:07:19 00:00         [chroot]============== test session starts 
> ===============
>                      platform darwin -- Python 2.7.10 -- py-1.4.31 -- 
> pytest-2.6.4
>                      plugins: timeout, cov
>                      collected 339 items 
>                      
>                      
> src/test/python/apache/aurora/client/cli/test_config_noun.py ...
>                      src/test/python/apache/aurora/client/cli/test_context.py 
> ........
>                      src/test/python/apache/aurora/client/cli/test_version.py 
> .
>                      src/test/python/apache/aurora/client/cli/test_quota.py 
> .....
>                      src/test/python/apache/aurora/client/cli/test_plugins.py 
> .
>                      src/test/python/apache/aurora/client/cli/test_client.py 
> ..
>                      src/test/python/apache/aurora/client/cli/test_sla.py 
> .....
>                      src/test/python/apache/aurora/client/cli/test_open.py 
> .....
>                      src/test/python/apache/aurora/client/cli/test_supdate.py 
> .............................
>                      src/test/python/apache/aurora/client/cli/test_restart.py 
> ..........
>                      src/test/python/apache/aurora/client/cli/test_status.py 
> .............
>                      src/test/python/apache/aurora/client/cli/test_add.py ....
>                      src/test/python/apache/aurora/client/cli/test_diff.py ..
>                      src/test/python/apache/aurora/client/cli/test_cron.py 
> ..........
>                      
> src/test/python/apache/aurora/client/cli/test_command_hooks.py ..
>                      src/test/python/apache/aurora/client/cli/test_options.py 
> ......
>                      src/test/python/apache/aurora/client/cli/test_task.py 
> .....
>                      src/test/python/apache/aurora/client/cli/test_create.py 
> ..............
>                      src/test/python/apache/aurora/client/cli/test_kill.py 
> .....................
>                      src/test/python/apache/aurora/client/cli/test_inspect.py 
> ...
>                      
> src/test/python/apache/aurora/client/cli/test_api_from_cli.py ..
>                      
> src/test/python/apache/aurora/client/cli/test_diff_formatter.py .....
>                      
> src/test/python/apache/aurora/client/api/test_updater_util.py .......
>                      
> src/test/python/apache/aurora/client/api/test_job_monitor.py ......
>                      src/test/python/apache/aurora/client/api/test_api.py 
> ..........
>                      
> src/test/python/apache/aurora/client/api/test_task_util.py .
>                      
> src/test/python/apache/aurora/client/api/test_restarter.py ......
>                      
> src/test/python/apache/aurora/client/api/test_instance_watcher.py ......
>                      
> src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> .....................................................................
>                      src/test/python/apache/aurora/client/api/test_sla.py 
> ......................................
>                      
> src/test/python/apache/aurora/client/api/test_health_check.py ...
>                      
> src/test/python/apache/aurora/client/hooks/test_hooked_api.py ............
>                      
> src/test/python/apache/aurora/client/hooks/test_non_hooked_api.py ...
>                      src/test/python/apache/aurora/client/test_config.py 
> ............
>                      
> src/test/python/apache/aurora/client/test_binding_helper.py ..
>                      src/test/python/apache/aurora/client/test_base.py 
> ........
>                      
>                      ========== 339 passed in 24.32 seconds ===========
>                      
> 14:07:45 00:26   [complete]
>                SUCCESS
> 
> 
> Thanks,
> 
> David McLaughlin
> 
>

Reply via email to