> On Aug. 5, 2016, 12:50 a.m., Joshua Cohen wrote:
> > This does not compile. We have -Werror set on our builds which means the 
> > warning about the field being deprecated causes a build failure.

If we do want to maintain this across a release boundary for compatibility sake 
we'll need to add a @SuppressWarnings annotation and also fix the 
MesosTaskFactoryImpl tests that break as a result of re-adding this field. 
Additionally we should add a ticket to remove this after the next release.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50826/#review144855
-----------------------------------------------------------


On Aug. 5, 2016, 12:34 a.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50826/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2016, 12:34 a.m.)
> 
> 
> Review request for Aurora, Joshua Cohen and Dmitriy Shirchenko.
> 
> 
> Bugs: AURORA-1745
>     https://issues.apache.org/jira/browse/AURORA-1745
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> b912e17 stopped populating the source field of the executor. For backwards 
> compatibility we should continue to populate this field and the `source` 
> label.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/mesos/MesosTaskFactory.java 
> 34134430063b2d24a4e20d3f91ab899604edaf89 
> 
> Diff: https://reviews.apache.org/r/50826/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to