> On Aug. 8, 2016, 10:54 p.m., Joshua Cohen wrote:
> > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java, 
> > line 133
> > <https://reviews.apache.org/r/50168/diff/10/?file=1462000#file1462000line133>
> >
> >     It feels like we should also be able to roll back an update in 
> > `ROLL_FORWARD_AWAITING_PULSE`. This is not currently possible based on the 
> > state machine. If a user tried to rollback an update that's stuck waiting 
> > for a pulse, they would first need to explicitly pause the update and then 
> > roll it back (since the PAUSED->ROLLING_BACK transition is allowed).
> >     
> >     Do you feel that this is problematic? It's certainly an edge case, but 
> > it seems like it could lead to confusion for a user who is desperately 
> > trying to roll back an update.
> >     
> >     We could update `JobUpdateStateMachine` to allow for the transition 
> > from `ROLL_FORWARD_AWAITING_PULSE` to `ROLLING_BACK`.

no, you are right. I will add a transition and a test case


- Igor


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50168/#review145144
-----------------------------------------------------------


On Aug. 3, 2016, 10:16 p.m., Igor Morozov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50168/
> -----------------------------------------------------------
> 
> (Updated Aug. 3, 2016, 10:16 p.m.)
> 
> 
> Review request for Aurora, Joshua Cohen, Maxim Khutornenko, Bill Farner, and 
> Zameer Manji.
> 
> 
> Bugs: AURORA-1721
>     https://issues.apache.org/jira/browse/AURORA-1721
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Add rollback functionality to the scheduler
> 
> 
> Diffs
> -----
> 
>   CHANGELOG fc6a46d77ebf889c8f60402c95e8a7472980ba1c 
>   RELEASE-NOTES.md 19d7f7e34652d170a7d8eb41a9c6ffdcc67324eb 
>   api/src/main/thrift/org/apache/aurora/gen/api.thrift 
> b799cce665c99ee20fba84a9ddcb5a895ff5685e 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java
>  b534abf95bab6e1657e3ef993cf34c0d6ec460be 
>   
> src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java
>  9243c92b11040b68ed6014b3991db69fc08bcddf 
>   src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java 
> f8357c46df1b025bf4e38a7ce1cb1c13a50c39f9 
>   
> src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java
>  364c5c753f884a2d89e27802d7bbf3b2b6d3a08e 
>   src/main/python/apache/aurora/client/api/__init__.py 
> ec2c786d143347a7953f9fe431c6ddc59e1b9854 
>   src/main/python/apache/aurora/client/cli/update.py 
> bb526f7bf94d7bfe02fe2786493c85be1bfeb86f 
>   src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java 
> e157c0dfde5efc418448e138aa008ade742fe816 
>   src/test/python/apache/aurora/client/api/test_scheduler_client.py 
> afbd385b7eda64cb1f7d118b695e65e4045eac6c 
>   src/test/python/apache/aurora/client/cli/test_supdate.py 
> 317b17547e8b33106787fbe43b26cec2da830ba1 
> 
> Diff: https://reviews.apache.org/r/50168/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Igor Morozov
> 
>

Reply via email to