----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50168/#review145558 -----------------------------------------------------------
Ship it! LGTM, it seems maxim and josh have really dug into the code before I had a chance. - Zameer Manji On Aug. 11, 2016, 11:07 a.m., Igor Morozov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50168/ > ----------------------------------------------------------- > > (Updated Aug. 11, 2016, 11:07 a.m.) > > > Review request for Aurora, Joshua Cohen, Maxim Khutornenko, and Zameer Manji. > > > Bugs: AURORA-1721 > https://issues.apache.org/jira/browse/AURORA-1721 > > > Repository: aurora > > > Description > ------- > > Add rollback functionality to the scheduler > > For active job updates in ROLLING_FORWARD, ROLL_BACK_PAUSED, > ROLL_BACK_AWAITING_PULSE, ROLL_FORWARD_PAUSED or ROLL_FORWARD_AWAITING_PULSE > state > it is possible now to initiate a rollback by calling a corresponding API > function. > Rollback is also supported in aurora CLI tool via new command: > aurora update rollback CLUSTER/ROLE/ENV/NAME > > > Diffs > ----- > > CHANGELOG fc6a46d77ebf889c8f60402c95e8a7472980ba1c > RELEASE-NOTES.md 50f9b8372b364773d4ee6b29f031deb13c9f6444 > api/src/main/thrift/org/apache/aurora/gen/api.thrift > b799cce665c99ee20fba84a9ddcb5a895ff5685e > > src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java > b534abf95bab6e1657e3ef993cf34c0d6ec460be > > src/main/java/org/apache/aurora/scheduler/thrift/aop/AnnotatedAuroraAdmin.java > 9243c92b11040b68ed6014b3991db69fc08bcddf > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateController.java > f8357c46df1b025bf4e38a7ce1cb1c13a50c39f9 > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateControllerImpl.java > 364c5c753f884a2d89e27802d7bbf3b2b6d3a08e > > src/main/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachine.java > 7ab739a4dfa292895ad6ba8849e65f5c45ce9770 > src/main/python/apache/aurora/client/api/__init__.py > ec2c786d143347a7953f9fe431c6ddc59e1b9854 > src/main/python/apache/aurora/client/cli/update.py > bb526f7bf94d7bfe02fe2786493c85be1bfeb86f > > src/test/java/org/apache/aurora/scheduler/updater/JobUpdateStateMachineTest.java > 8d78bae2cbf365a5359d88c0e996b3972a21e50e > src/test/java/org/apache/aurora/scheduler/updater/JobUpdaterIT.java > e157c0dfde5efc418448e138aa008ade742fe816 > src/test/python/apache/aurora/client/api/test_scheduler_client.py > afbd385b7eda64cb1f7d118b695e65e4045eac6c > src/test/python/apache/aurora/client/cli/test_supdate.py > 317b17547e8b33106787fbe43b26cec2da830ba1 > > Diff: https://reviews.apache.org/r/50168/diff/ > > > Testing > ------- > > > Thanks, > > Igor Morozov > >