-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51192/#review146082
-----------------------------------------------------------


Ship it!




lgtm modulo the below.


docs/operations/configuration.md 
<https://reviews.apache.org/r/51192/#comment212458>

    I'd say leave something along these lines this in this file with a link to 
the full documentation?


- Joshua Cohen


On Aug. 17, 2016, 10:52 p.m., Renan DelValle wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51192/
> -----------------------------------------------------------
> 
> (Updated Aug. 17, 2016, 10:52 p.m.)
> 
> 
> Review request for Aurora.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Moved custom executor documentation from docs/operations/configuration.md 
> since it grew out of proportion.
> Added an explaination on how a thrift object needs to be configured in a 
> createJob call and referenced using a custom Client for now.
> 
> 
> Diffs
> -----
> 
>   docs/additional-resources/tools.md 64a4f74f38240fa85336105fd4f1c8c6771de852 
>   docs/features/custom-executors.md PRE-CREATION 
>   docs/operations/configuration.md bbcffac686cddb97f8a137afce1ed50a260b7359 
> 
> Diff: https://reviews.apache.org/r/51192/diff/
> 
> 
> Testing
> -------
> 
> None, doc changes only.
> 
> 
> Thanks,
> 
> Renan DelValle
> 
>

Reply via email to