-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51306/
-----------------------------------------------------------

Review request for Aurora and Zameer Manji.


Bugs: AURORA-1719
    https://issues.apache.org/jira/browse/AURORA-1719


Repository: aurora


Description
-------

Only warn about terminated executors if their exit code is not 0.

I have left a comment in the corresponding Mesos issue 
(https://issues.apache.org/jira/browse/MESOS-313?focusedCommentId=15431688&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15431688),
 so hopefully we can remove that guard here in the future.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/mesos/MesosSchedulerImpl.java 
df87d92d357addee75e8c2d6edea28879035b726 

Diff: https://reviews.apache.org/r/51306/diff/


Testing
-------

Checked in vagrant that

* a clean executor termination does not produce any logs
* killing an executor with -9 results in a log entry such as `W0822 
22:16:47.961 [Thread-26, MesosSchedulerImpl:259] Lost executor value: 
"thermos-www-data-prod-hello-0-61a39fd7-297a-417f-8ed7-d71b4634ca36" on slave 
value: "b1593d6b-7a7e-458c-ab22-6a5d07b9f065-S0" with status 9`


Thanks,

Stephan Erb

Reply via email to