> On Aug. 22, 2016, 10:41 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/common/sandbox.py, line 235
> > <https://reviews.apache.org/r/51298/diff/1/?file=1481195#file1481195line235>
> >
> >     ... then this if would not be needed.

One could potentially invoke the sandbox creation from elsewhere which could 
lead to the same case where we would fail to iterate. I figured it was better 
to make the handling of a `None` value explicit.


> On Aug. 22, 2016, 10:41 p.m., Stephan Erb wrote:
> > src/main/python/apache/aurora/executor/common/sandbox.py, line 244
> > <https://reviews.apache.org/r/51298/diff/1/?file=1481195#file1481195line244>
> >
> >     When I remember your previous patch correctly, then the current working 
> > directory of our processes is set to the mesos_directory. This would imply 
> > that specifying an alternative sandbox mount point could break things.

Good catch. I cleaned up the cwd handling, which led to a bit of a rabbit hole 
of other fixes, but on the bright side, everything seems to work properly as 
far as bind mounting the sandbox directory into the taskfs.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51298/#review146449
-----------------------------------------------------------


On Aug. 22, 2016, 8:25 p.m., Joshua Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51298/
> -----------------------------------------------------------
> 
> (Updated Aug. 22, 2016, 8:25 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> - Add an option to skip the groupadd/useradd calls into the task's filesystem.
> - Mount any configured volumes into the task's filesystem.
> - Clean up http server script used by appc e2e tests.
> 
> 
> Diffs
> -----
> 
>   src/main/python/apache/aurora/executor/aurora_executor.py 
> dde19a6914c7c7b2178220707f242f61f11f38bd 
>   src/main/python/apache/aurora/executor/bin/thermos_executor_main.py 
> 65a495d5c50d91b38c4328bab3bfec667f6a7ba9 
>   src/main/python/apache/aurora/executor/common/sandbox.py 
> 5f091af7636bd94f028f15d63437e305b02f741c 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> ce989b1ccda0f1bc7ba9e15dfe4be20116db3491 
>   src/test/python/apache/aurora/executor/test_thermos_executor.py 
> 06601df3bc355a690ff1789b2e2e34484fadefe9 
>   src/test/sh/org/apache/aurora/e2e/run-server.sh 
> 76939888bed2e8138671d97f7bc56fd5641008e4 
> 
> Diff: https://reviews.apache.org/r/51298/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> e2e tests
> 
> 
> Thanks,
> 
> Joshua Cohen
> 
>

Reply via email to