> On Aug. 29, 2016, 4:39 p.m., John Sirois wrote:
> > I'm taking a look presently.  The seperate script call-out should no longer 
> > be needed since `./pants test...` implies `./pants compile...` which is all 
> > the seperate script does.
> 
> John Sirois wrote:
>     Aha - yes, the compile dependency was historically leeched from the jvm 
> stack which is now not installed.  LGTM.
> 
> John Sirois wrote:
>     Filed pants issue to fix this: 
> https://github.com/pantsbuild/pants/issues/3819

I was just talking to Stu Hood in pants slack about this. He came to the same 
conclusion (removing the JVM backend caused test to no longer be linked to 
compile). He suggested we might want to install a plugin to redirect 
pythonstyle to the test goal instead.

I think that this solution is probably ok for my use cases (checking style 
before posting a review and having ReviewBot catch style issues for me so I 
don't have to call them out myself on other reviews), but wanted to raise the 
option for those who might like to have checkstyle run during the local dev 
flow of edit/test/repeat.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51484/#review147139
-----------------------------------------------------------


On Aug. 28, 2016, 4:40 a.m., Santhosh Kumar Shanmugham wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51484/
> -----------------------------------------------------------
> 
> (Updated Aug. 28, 2016, 4:40 a.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Re-enable python style check in the integration build.
> 
> pants test does not appear to invoke the python checkstyle. Re-enable
> it by explicitly calling in the integration build script. Also fix the
> few issues that have already been commited.
> 
> 
> Diffs
> -----
> 
>   build-support/jenkins/build.sh 1de144628f0e687eb3a191b0aa819bae018a8f37 
>   src/main/python/apache/aurora/client/cli/context.py 
> f1a256a8d09d23d8d4d4ee7d264be0fe376398c4 
>   src/main/python/apache/aurora/client/cli/update.py 
> 23aaa2c1b67599420408633733e4581553f7151b 
>   src/main/python/apache/thermos/core/process.py 
> 78e7d788f14a1611031e3c6e255c77768daabac4 
>   src/test/python/apache/aurora/executor/common/test_sandbox.py 
> b30a5bc733ac5ccace0b93b68e2ee6f04ce31184 
>   src/test/python/apache/thermos/core/test_process.py 
> 49f52d947471c8ea8daae1708f4d26afa4c6ee0a 
> 
> Diff: https://reviews.apache.org/r/51484/diff/
> 
> 
> Testing
> -------
> 
> ./build-support/jenkins/build.sh
> 
> 
> Thanks,
> 
> Santhosh Kumar Shanmugham
> 
>

Reply via email to