> On Aug. 29, 2016, 4:33 p.m., Maxim Khutornenko wrote:
> > Not against this change but rather curious what your thoughts are wrt the 
> > larger picture here. Are you intending to get rid of all static helps in 
> > `Stats` in favor of the `StatsProvider`?
> 
> Zameer Manji wrote:
>     Yes, I think the static dependency on stats is tech debt that we need to 
> fix. There is also lots of unused code in Stats that I will be removing as 
> well.

Not sure I agree about eliminating all of `Stats` static helpers. Having 
methods like `exportLong` have proven to help us reduce friction around adding 
new stats and generally help quick prototyping and perf investigations.


- Maxim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51469/#review147138
-----------------------------------------------------------


On Aug. 26, 2016, 10:11 p.m., Zameer Manji wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51469/
> -----------------------------------------------------------
> 
> (Updated Aug. 26, 2016, 10:11 p.m.)
> 
> 
> Review request for Aurora and Joshua Cohen.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Remove static Stats method `exportSize`.
> 
> 
> Diffs
> -----
> 
>   commons/src/main/java/org/apache/aurora/common/stats/Stats.java 
> 538e8077ba762ec9a8f14f759740bb82144a5dc4 
>   commons/src/main/java/org/apache/aurora/common/stats/StatsProvider.java 
> 6b1fa4b35c54ab3e37a80c91664c6e8cfd4696c2 
>   src/main/java/org/apache/aurora/scheduler/TaskStatusHandlerImpl.java 
> a83f18307fd8e1d266f3d3ae8682333575eda884 
>   src/main/java/org/apache/aurora/scheduler/offers/OfferManager.java 
> a1ae7c7231d15d2f9715a7de30dfcde0a2f4d730 
>   src/test/java/org/apache/aurora/scheduler/TaskStatusHandlerImplTest.java 
> 6d4934b6b6de5273687041174315c4e3d151ac11 
>   src/test/java/org/apache/aurora/scheduler/offers/OfferManagerImplTest.java 
> e7534c4325afa29b580d890cffdc26bdec7ef938 
> 
> Diff: https://reviews.apache.org/r/51469/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Zameer Manji
> 
>

Reply via email to