> On Aug. 29, 2016, 4:04 p.m., Aurora ReviewBot wrote:
> > Master (c34f78a) is red with this patch.
> >   ./build-support/jenkins/build.sh
> > 
> > Successfully installed Markdown-2.1.1 Pygments-1.4 ansicolors-1.0.2 
> > cov-core-1.15.0 coverage-3.7.1 docutils-0.12 fasteners-0.14.1 futures-3.0.5 
> > lmdb-0.89 monotonic-1.2 pantsbuild.pants-1.1.0rc7 pathspec-0.3.4 pex-1.1.10 
> > psutil-4.3.0 py-1.4.31 pystache-0.5.3 pytest-2.6.4 pytest-cov-1.8.1 
> > pywatchman-1.3.0 requests-2.5.3 scandir-1.2 setproctitle-1.1.10 
> > setuptools-5.4.1 six-1.10.0 twitter.common.collections-0.3.7 
> > twitter.common.confluence-0.3.7 twitter.common.dirutil-0.3.7 
> > twitter.common.lang-0.3.7 twitter.common.log-0.3.7 
> > twitter.common.options-0.3.7
> > 
> > 22:03:11 00:00 [main]
> >                (To run a reporting server: ./pants server)
> > 22:03:11 00:00   [setup]
> > 22:03:11 00:00     [parse]
> >                Executing tasks in goals: compile
> > 22:03:11 00:00   [compile]
> > 22:03:11 00:00     [compile-prep-command]
> > 22:03:11 00:00     [compile]
> > 22:03:11 00:00     [python-eval]
> > 22:03:11 00:00     [pythonstyle]
> > 22:03:11 00:00       [cache]                                          
> >                    No cached artifacts for 42 targets.
> >                    Invalidated 42 targets.
> > 22:03:34 00:23   [complete]
> >                SUCCESS
> > + ./pants test.pytest 
> > --junit-xml-dir=/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/test-results
> >  src/main/python:: src/test/python:: -- -v
> > 
> > 22:03:35 00:00 [main]
> >                (To run a reporting server: ./pants server)
> > 22:03:35 00:00   [setup]
> > 22:03:35 00:00     [parse]
> >                Executing tasks in goals: test
> > 22:03:35 00:00   [test]
> > 22:03:35 00:00     [test-prep-command]
> > 22:03:35 00:00     [test]
> > 22:03:35 00:00     [pytest]
> > 22:03:35 00:00       [run]
> >                      
> > 22:03:38 00:03         [chroot]INFO] Attempting to fetch thrift binary 
> > from: 
> > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
> >  ...
> > 
  2% .                                                    610 KB
  4% ..                                                  1220 KB
  6% ...                                                 1830 KB
  8% ....                                                2440 KB
 10% .....                                               3050 KB
 12% ......                                              3660 KB
 14% .......                                             4260 KB
 16% ........                                            4870 KB
 18% .........                                           5480 KB
 20% ..........                                          6090 KB
 22% ...........                                         6700 KB
 24% ............                                        7310 KB
 26% .............                                       7920 KB
 28% ..............                                      8520 KB
 30% ...............                                     9130 KB
 32% ................                                    9740 KB
 34% .................                                  10350 KB
 36% ..................                                 10960 KB
 38% ...................                                11570 KB
 40% ....................                               12170 KB
 42% .....................                              12780 KB
 44% ......................                             13390 KB
 46% .......................                            14000 KB
 48% ........................                           14610 KB
 50% .........................                          15220 KB
 52% ..........................                         15830 KB
 54% ...........................                        16430 KB
 56% ............................                       17040 KB
 58% .............................                      17650 KB
 60% ..............................                     18260 KB
 62% ...............................                    18870 KB
 64% ................................                   19480 KB
 66% .................................                  20090 KB
 68% ..................................                 20690 KB
 70% ...................................                21300 KB
 72% ....................................               21910 KB
 74% .....................................              22520 KB
 76% ......................................             23130 KB
 78% .......................................            23740 KB
 80% ........................................           24340 KB
 82% .........................................          24950 KB
 84% ..........................................         25560 KB
 86% ...........................................        26170 KB
 88% ............................................       26780 KB
 90% .............................................      27390 KB
 92% ..............................................     28000 KB
 94% ...............................................    28600 KB
 96% ................................................   29210 KB
 98% .................................................  29820 KB
100% .................................................. 30424 KB 1.447s
> > INFO] Fetched thrift binary from: 
> > https://dl.bintray.com/pantsbuild/bin/build-support/bin/thrift/linux/x86_64/0.9.1/thrift
> >  .
> > 
> > 22:03:42 00:07   [complete]
> >                FAILUREException caught: (<type 
> > 'exceptions.UnicodeEncodeError'>)
> > 
> > Exception message: 'latin-1' codec can't encode characters in position 
> > 51-55: ordinal not in range(256)
> > 
> > 
> > 
> > 
> > I will refresh this build result if you post a review containing 
> > "@ReviewBot retry"
> 
> John Sirois wrote:
>     OK - I was hoping to get more detail in the AuroraBot jenkins job 
> console, but this is it.  I'll dig a bit.
> 
> Stephan Erb wrote:
>     Could it be the new requests version combined with non optimal isolation?
> 
> John Sirois wrote:
>     It could be.  It could also just be poor isolation + a new machine in the 
> jenkins cluster with latin-1 as the default or only encoding available.
> 
> John Sirois wrote:
>     Luckily I can repro on my LANG=en_US.UTF-8 machine via: 
> `LANG=en_US.ISO-8859-1 ./pants test.pytest src/main/python:: 
> src/test/python:: -- -v`
> 
> John Sirois wrote:
>     Definitely one of the new deps, a problem setting up the dep down in pex 
> code:
>     ```
>     rm -rf ~/.cache/pants/bin/thrift
>     LANG=en_US.ISO-8859-1 ./pants --print-exception-stacktrace test.pytest 
> src/main/python:: src/test/python:: -- -v
>     ...
>      File 
> "/home/jsirois/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/lib/python2.7/site-packages/pants/backend/python/tasks/pytest_run.py",
>  line 423, in _test_runner
>         extra_requirements=self._TESTING_TARGETS)
>       File 
> "/home/jsirois/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/lib/python2.7/site-packages/pants/backend/python/tasks/python_task.py",
>  line 155, in cached_chroot
>         extra_requirements, executable_file_content)
>       File 
> "/home/jsirois/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/lib/python2.7/site-packages/pants/backend/python/tasks/python_task.py",
>  line 190, in _build_chroot
>         chroot.dump()
>       File 
> "/home/jsirois/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/lib/python2.7/site-packages/pants/backend/python/python_chroot.py",
>  line 227, in dump
>         distributions = self._resolve_multi(reqs_to_build, find_links)
>       File 
> "/home/jsirois/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/lib/python2.7/site-packages/pants/backend/python/python_chroot.py",
>  line 266, in _resolve_multi
>         cache_ttl=self._python_setup.resolver_cache_ttl)
>       File 
> "/home/jsirois/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/lib/python2.7/site-packages/pex/resolver.py",
>  line 346, in resolve
>         return resolver.resolve(resolvables_from_iterable(requirements, 
> builder))
>       File 
> "/home/jsirois/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/lib/python2.7/site-packages/pex/resolver.py",
>  line 200, in resolve
>         dist = self.build(package, resolvable.options)
>       File 
> "/home/jsirois/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/lib/python2.7/site-packages/pex/resolver.py",
>  line 257, in build
>         dist = super(CachingResolver, self).build(package, options)
>       File 
> "/home/jsirois/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/lib/python2.7/site-packages/pex/resolver.py",
>  line 166, in build
>         dist = translator.translate(local_package)
>       File 
> "/home/jsirois/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/lib/python2.7/site-packages/pex/translator.py",
>  line 45, in translate
>         dist = tx.translate(package, into=into)
>       File 
> "/home/jsirois/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/lib/python2.7/site-packages/pex/translator.py",
>  line 91, in translate
>         unpack_path = Archiver.unpack(package.local_path)
>       File 
> "/home/jsirois/.cache/pants/setup/bootstrap-Linux-x86_64/1.1.0-rc7/lib/python2.7/site-packages/pex/archiver.py",
>  line 48, in unpack
>         package.extractall(path=path)
>       File "/usr/lib64/python2.7/zipfile.py", line 1040, in extractall
>         self.extract(zipinfo, path, pwd)
>       File "/usr/lib64/python2.7/zipfile.py", line 1028, in extract
>         return self._extract_member(member, path, pwd)
>       File "/usr/lib64/python2.7/zipfile.py", line 1083, in _extract_member
>         file(targetpath, "wb") as target:
>     
>     Exception message: 'latin-1' codec can't encode characters in position 
> 51-55: ordinal not in range(256)
>     ```
> 
> John Sirois wrote:
>     CherryPy:
>     
>     ```
>     ...
>     17:24:18 00:01         [chroot]Unpacking package CherryPy...
>     Extracting /tmp/tmp8LEeNF/CherryPy-7.1.0.zip...
>     
>     17:24:26 00:09   [complete]
>                    FAILURE
>     Exception caught: (<type 'exceptions.UnicodeEncodeError'>)
>     
>     ...
>     ```
>     
>     With that 1 line in requirements.txt reverted, this goes green.

Looks like UTF-8 encoded test files got added in 6.0.0, so you should be able 
to use the prior release - 5.6.0 for now.
I've filed https://github.com/pantsbuild/pants/issues/3823


- John


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51499/#review147224
-----------------------------------------------------------


On Aug. 29, 2016, 1:11 p.m., Stephan Erb wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51499/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2016, 1:11 p.m.)
> 
> 
> Review request for Aurora, John Sirois and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> I have skimmed the changelogs and there does not seem to be anything
> worth calling out in particular. Full changelogs:
> 
> * https://github.com/cherrypy/cherrypy/blob/v7.1.0/CHANGES.txt
> * http://docs.makotemplates.org/en/latest/changelog.html
> * https://github.com/pantsbuild/pex/blob/v1.1.14/CHANGES.rst
> * https://github.com/giampaolo/psutil/blob/release-4.3.0/HISTORY.rst
> * https://github.com/requests/requests-kerberos/blob/v0.10.0/HISTORY.rst
> * https://github.com/kennethreitz/requests/blob/v2.11.1/HISTORY.rst
> 
> 
> I have skipped the following updates for now:
> 
> * bottle: has a conflicting requirement in common
> * mock: it leads to some test failures
> * thrift: I didn't date to touch that
> 
> 
> Diffs
> -----
> 
>   3rdparty/python/requirements.txt 5cc3cb1edf7dcf30e44ff094e90286df48fa445e 
> 
> Diff: https://reviews.apache.org/r/51499/diff/
> 
> 
> Testing
> -------
> 
> ./pants test.pytest src/{main,test}/python:: -- -v
> ./src/test/sh/org/apache/aurora/e2e/test_end_to_end.sh
> 
> 
> Thanks,
> 
> Stephan Erb
> 
>

Reply via email to