----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51513/#review147270 -----------------------------------------------------------
Were you able to test this on a cluster with concurrent modifications? Right now, I am not confident this is working as most ouf our thrift responses contain unordered sequences. I would therefore suspect that we get a different hash each time, even though the content itself has not changed. Considering it is working in some cases, do we have to do something to get some speedups for the Aurora UI as well? - Stephan Erb On Aug. 30, 2016, 3:12 a.m., Zameer Manji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51513/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 3:12 a.m.) > > > Review request for Aurora, Joshua Cohen and Stephan Erb. > > > Bugs: AURORA-1757 > https://issues.apache.org/jira/browse/AURORA-1757 > > > Repository: aurora > > > Description > ------- > > This patch enhances the Aurora API by producing an `ETag` header for each API > request. It also consumes etag values in API requests via the `If-None-Match` > header and produces a HTTP 304 if the request would produce a body with the > same > etag value. > > > Diffs > ----- > > RELEASE-NOTES.md 1819eaa20cf5014228643a1e120316d646cc2824 > > src/main/java/org/apache/aurora/scheduler/http/api/TContentAwareServlet.java > 1634cb88ac09c778c5bb277ca902f4ca35dd6c9d > src/test/java/org/apache/aurora/scheduler/http/api/ApiIT.java > 0a3ff05586c87e0ab2cc20470e99b5dd609f7039 > > Diff: https://reviews.apache.org/r/51513/diff/ > > > Testing > ------- > > > Thanks, > > Zameer Manji > >
